[RFE] Add a flag to always perform persistent boot

Bug #1703945 reported by Fellype Cavalcante
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Wishlist
Stenio Araujo

Bug Description

With the proposal to solve the bug that PXE interface should be using non-persistent boot for cleaning/deploying phases as default[1], it will be necessary to create a flag to enable this persistent behavior when you set the boot device. This flag would override a non-persistent behavior in the cleaning and deploy process.

There are two places we could handle this flag:

1. The first is a more general solution to activate only in PXE, and would make all PXE's as persistent boot order.
Something like:
    persistent = strutils.bool_from_string(
        node.driver_info.get('force_always_pxe_persistent_boot_devices,False))
            manager_utils.node_set_boot_device(task, boot_devices.PXE,
                                               persistent=persistent)

2.The other one is to define this behavior by driver, creating a flag for each driver and set it in the management interface set_boot_device method.
Something like:
    def set_boot_device(self, task, device, persistent=False):
       if node.driver_info.get(
       'oneview_force_always_persistent_boot_devices', False):
            persistent=True

An example of this behavior can be seen at ipmitool management interface that already handles a similar flag for the case when some IPMI BMCs don't support persistent boot devices[2].

An extended discussion about this bug can be found at [3] and [4]. Search for: fellypefca, TheJulia and sambetts.

[1] - https://review.openstack.org/#/c/479927/
[2] - https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ipmitool.py#L915
[3] - http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2017-06-29.log.html#t2017-06-29T12:00:01
[4] - http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2017-07-12.log.html#t2017-07-12T12:54:35

description: updated
Changed in ironic:
assignee: nobody → Fellype Cavalcante (fellypefca)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/483430

Changed in ironic:
status: New → In Progress
Changed in ironic:
assignee: Fellype Cavalcante (fellypefca) → Stenio Araujo (stenioaraujo)
Changed in ironic:
assignee: Stenio Araujo (stenioaraujo) → Fellype Cavalcante (fellypefca)
Changed in ironic:
assignee: Fellype Cavalcante (fellypefca) → Stenio Araujo (stenioaraujo)
Changed in ironic:
assignee: Stenio Araujo (stenioaraujo) → Fellype Cavalcante (fellypefca)
Changed in ironic:
assignee: Fellype Cavalcante (fellypefca) → Stenio Araujo (stenioaraujo)
Dmitry Tantsur (divius)
Changed in ironic:
importance: Undecided → Wishlist
summary: - Add a flag to always peform persistent boot
+ [RFE] Add a flag to always perform persistent boot
Dmitry Tantsur (divius)
tags: added: rfe-approved
removed: rfe
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/483430
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=049fd407196c0eb5846f5ff63f2cbc482afa4d89
Submitter: Jenkins
Branch: master

commit 049fd407196c0eb5846f5ff63f2cbc482afa4d89
Author: Fellype Cavalcante <email address hidden>
Date: Thu Jul 13 10:22:29 2017 -0300

    Add a flag to always perform persistent boot on PXE interface

    With the proposal to solve the bug that PXE interface should
    be using non-persistent boot for cleaning/deploying phases as
    default(commit: c7091fb8e2898e526f8ce242f50096a2cabeb1fa), it's
    necessary to create a flag to enable persistent behavior when
    you set the boot device.
    This flag will override a non-persistent behavior in the
    cleaning and deploy process.

    Change-Id: I1f47393c17a3f5319fffd963ec0a016b41865c5d
    Closes-Bug: 1703945
    Co-Authored-By: Stenio Araujo <email address hidden>

Changed in ironic:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ironic 9.0.0

This issue was fixed in the openstack/ironic 9.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to ironic (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/494751

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to ironic (stable/pike)

Related fix proposed to branch: stable/pike
Review: https://review.openstack.org/495809

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to ironic (stable/pike)

Reviewed: https://review.openstack.org/495809
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=9a424bc318cd9322fcc8dcb9dd8ce7dc485c3530
Submitter: Jenkins
Branch: stable/pike

commit 9a424bc318cd9322fcc8dcb9dd8ce7dc485c3530
Author: Ruby Loo <email address hidden>
Date: Thu Aug 17 20:40:49 2017 -0400

    Add 'force_persistent_boot_device' to pxe props

    Adds 'force_persistent_boot_device' to the pxe driver/interface's
    list of properties. This property was added as part of commit
    049fd407196c0eb5846f5ff63f2cbc482afa4d89.

    Change-Id: Ie4549fe437c0a2b06a7d5e2dc0725d0990ed6d67
    Related-Bug: 1703945
    (cherry-picked from commit 43b53ab28f0867db94be5f26ab2444d52f66d1ea)

tags: added: in-stable-pike
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.