Grenade jobs broken by not finding iniset_rpc_backend

Bug #1700548 reported by Vladyslav Drok
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
High
Vladyslav Drok
Networking ML2 Generic Switch
Fix Released
High
Vladyslav Drok

Bug Description

Caused by https://review.openstack.org/436094, start_nova_compute now triggers iniset_rpc_backend, and we don't source the file containing it during the upgrade.

As the comment in that patch says, multicell setup is not supported in grenade, so we need to pass nuomulticess parameters in the grenade plugins.

Vladyslav Drok (vdrok)
Changed in ironic:
importance: Undecided → Critical
status: New → Confirmed
Changed in networking-generic-switch:
importance: Undecided → High
status: New → Confirmed
Changed in ironic:
assignee: nobody → Vladyslav Drok (vdrok)
status: Confirmed → In Progress
Revision history for this message
Vladyslav Drok (vdrok) wrote :
Changed in networking-generic-switch:
assignee: nobody → Vladyslav Drok (vdrok)
Vladyslav Drok (vdrok)
description: updated
Changed in networking-generic-switch:
status: Confirmed → In Progress
Revision history for this message
Vladyslav Drok (vdrok) wrote :

Scratch comment #1, the patch do n-g-s is at https://review.openstack.org/477401 and to ironic is at https://review.openstack.org/477313

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on networking-generic-switch (master)

Change abandoned by Vladyslav Drok (<email address hidden>) on branch: master
Review: https://review.openstack.org/477523

Revision history for this message
milan k (vetrisko) wrote :

...btw inspector suffers the same (was reported as https://bugs.launchpad.net/ironic/+bug/1700525)...

Revision history for this message
Vladyslav Drok (vdrok) wrote :

Not critical anymore, devstack revert merged

Changed in ironic:
importance: Critical → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-generic-switch (master)

Reviewed: https://review.openstack.org/477401
Committed: https://git.openstack.org/cgit/openstack/networking-generic-switch/commit/?id=4e7c7313e0f330cc59e1e19cadd730175211de3f
Submitter: Jenkins
Branch: master

commit 4e7c7313e0f330cc59e1e19cadd730175211de3f
Author: Hironori Shiina <email address hidden>
Date: Mon Jun 26 15:25:47 2017 +0900

    Set nomulticell flag for starting nova-compute in upgrade

    This patch set nomulitcell flag when starting nova-compute because
    multi-cell rabbit setup is not supported in Grenade.

    Closes-Bug: 1700548

    Change-Id: I4462b88dde778f316896013d4098936cdeec6b76

Changed in networking-generic-switch:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ironic (master)

Change abandoned by Dmitry Tantsur (<email address hidden>) on branch: master
Review: https://review.openstack.org/477522
Reason: not needed?

Changed in ironic:
assignee: Vladyslav Drok (vdrok) → Hironori Shiina (shiina-hironori)
Revision history for this message
Hironori Shiina (shiina-hironori) wrote :

With https://review.openstack.org/#/c/477313/
gate-ironic-dsvm-standalone-ubuntu-xenial will work.

For gate-grenade-dsvm-ironic-multinode-multitenant-ubuntu-xenial,
there is another issue the that fixed upgrade.sh in networking-generic-switch doesn't run.
It seems caused by overwriting a directory name(GITDIR[networking-generic-switch]) from 'new' to 'old' by enable_plugin here[1] due to naming conflict in Grenade and DevStack.

[1] https://github.com/openstack/ironic/blob/fdf6f89a231870fc230c4b15caf098be34d498f1/devstack/upgrade/settings#L15
[2] https://github.com/openstack-dev/grenade/blob/11dd94308ed5c25a8f28f86b03b20b251f0a05a1/inc/plugin#L163
[3] https://github.com/openstack-dev/devstack/blob/2967ca3dfd0d64970dfa5dfa7ac2330ee7aa90ed/functions-common#L1890

Revision history for this message
Vladyslav Drok (vdrok) wrote :

Hironori, yup, you're right. Trying things to fix it at https://review.openstack.org/477655

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-generic-switch (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/480894

Changed in ironic:
assignee: Hironori Shiina (shiina-hironori) → Vladyslav Drok (vdrok)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-generic-switch (stable/ocata)

Reviewed: https://review.openstack.org/480894
Committed: https://git.openstack.org/cgit/openstack/networking-generic-switch/commit/?id=fa47ca56d43aac1d03738d63910bc3ab83aeb568
Submitter: Jenkins
Branch: stable/ocata

commit fa47ca56d43aac1d03738d63910bc3ab83aeb568
Author: Hironori Shiina <email address hidden>
Date: Mon Jun 26 15:25:47 2017 +0900

    Set nomulticell flag for starting nova-compute in upgrade

    This patch set nomulitcell flag when starting nova-compute because
    multi-cell rabbit setup is not supported in Grenade.

    Closes-Bug: 1700548

    Change-Id: I4462b88dde778f316896013d4098936cdeec6b76
    (cherry picked from commit 4e7c7313e0f330cc59e1e19cadd730175211de3f)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/477313
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=b0608771e53f9a12960fe229bcd2960317a58c86
Submitter: Jenkins
Branch: master

commit b0608771e53f9a12960fe229bcd2960317a58c86
Author: Hironori Shiina <email address hidden>
Date: Mon Jun 26 11:42:52 2017 +0900

    Set nomulticell flag for starting nova-compute in grenade

    This patch set nomulitcell flag when starting nova-compute because
    multi-cell rabbit setup is not necessary in Grenade. This nomulticell
    flag will be introduced with I08d7da843d18b426dda8a8a231039d950a4c0ce5.

    Closes-Bug: 1700548
    Change-Id: Ib55f6359751052d41b46e31ec8e15f46e33c1193

Changed in ironic:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ironic 9.0.0

This issue was fixed in the openstack/ironic 9.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/networking-generic-switch ocata-eol

This issue was fixed in the openstack/networking-generic-switch ocata-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.