[RFE] Switch the OneView driver to hpOneView and ilorest libraries

[Stenio Araujo]

When HPE OneView drivers for OpenStack Ironic started being developed, server management related features where not yet available at python-hpOneView [1], which was the default python client for accessing HPE OneView API. As these features were not a high priority to the team responsible for python-hpOneView, we started the development of python-oneviewclient [2] to fill this need.

In the meantime, python-hpOneView was already being used by networking-oneview [3], a HPE OneView mechanism driver for Neutron ML2 plugin.

An effort is needed now to migrate current Ironic interfaces using python-oneviewclient to python-hpOneView, as the first has not received any new features in the last year while python-hpOneView has reached a stable coverage point of HPE OneView API.

Also, python-oneviewclient hosted Ironic related validations code [4], and this should not be part of a client lib, so it won't be migrated to python-hpOneView but to Ironic code base itself.

We expect that with the removal of this dependency on python-oneviewclient, the team maintaining the Ironic interfaces will have a better chance to cooperate with the team developing python-hpOneView and enhance the drivers.

[1] - https://github.com/hewlettPackard/python-hpOneView
[2] - https://github.com/openstack/python-oneviewclient
[3] - https://github.com/HewlettPackard/ironic-driver-oneview/tree/master/networking-oneview
[4] - https://github.com/openstack/python-oneviewclient/blob/master/oneview_client/client.py#L612

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/468428

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/480284

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/468129
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=3a5288a9adcb184ac4cc371816dc2ffa18695bbb
Submitter: Jenkins
Branch: master

commit 3a5288a9adcb184ac4cc371816dc2ffa18695bbb
Author: Hugo Nicodemos <email address hidden>
Date: Thu Jun 29 16:53:47 2017 -0300

    Introduce hpOneView and ilorest to OneView

    It introduces the hpOneView and ilorest library to the OneView
    Driver. This patch will be used as the standard patch to other
    patches related to the removal of the python-oneviewclient
    library dependency.

    Partial-Bug: #1693788
    Change-Id: I77a220e8dc7099850aa5edb7a51e19ae486675a9

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/466872
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=0ed998dfc81109f3a09100cb3b128e692be92e20
Submitter: Jenkins
Branch: master

commit 0ed998dfc81109f3a09100cb3b128e692be92e20
Author: Xavier <email address hidden>
Date: Mon May 22 15:34:41 2017 -0300

    Migrate oneview driver to use python-hpOneView

    Migrate the code on OneView drivers to stop using python-oneviewclient in
    order to use python-hpOneView and python-ilorest-library. The library
    python-hpOneView is more recent and is being more actively developed and
    maintained.

    Co-Authored-By: Rodrigo Farias <email address hidden>
    Co-Authored-By: Hugo Nicodemos <email address hidden>

    Change-Id: I731964749cb79da7178882dfc09b3fe54d8e73b4
    Partial-Bug: #1693788

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/468428
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=c2eb357aa1a92670745d282423154e62709f570f
Submitter: Zuul
Branch: master

commit c2eb357aa1a92670745d282423154e62709f570f
Author: Hugo Nicodemos <email address hidden>
Date: Mon Oct 9 16:19:09 2017 -0300

    Migrate python-oneviewclient validations to Ironic OneView drivers

    As part of the process to stop the use of python-oneviewclient
    in favor of python-hpOneView and python-ilorest-library, the
    validations of the python-oneviewclient have to be migrated to
    the Ironic OneView drivers.

    Change-Id: If1eb72192ed58b7d3b8bae780924879fed947a77
    Partial-Bug: #1693788

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/480284
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=037360f64d5db7401df1d656fa8f1932011b5587
Submitter: Zuul
Branch: master

commit 037360f64d5db7401df1d656fa8f1932011b5587
Author: Hugo Nicodemos <email address hidden>
Date: Tue Jul 4 14:07:03 2017 -0300

    Remove python-oneviewclient from Ironic OneView drivers

    This patch removes the python-oneviewclient library from
    OneView drivers since it was migrated to python-hponeview
    and python-ilorest-library.

    Change-Id: I061381a941e7d7f82863b326bb7555d41395e661
    Closes-Bug: #1693788

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/510644
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=faf3f6b210b3c3ed604c55efb79b0db1936b7fad
Submitter: Zuul
Branch: master

commit faf3f6b210b3c3ed604c55efb79b0db1936b7fad
Author: Stenio Araujo <email address hidden>
Date: Mon Oct 9 14:48:47 2017 -0300

    Get a new OneView client when needed

    OneView has the time to expire an active session
    defined through an idle time. This idle time is
    24 hours by default. The previous client,
    python-oneviewclient, used by the hardware type
    OneView had a reauthentication mechanism that would
    ensure the new session was created when the old
    one expired. With the migration to python-hpOneView,
    the mechanism to reauthenticate does not exist.

    This solution creates a new instance of the client when
    it is needed.

    Change-Id: Id112e84f7d050d818e3cd9bf02cd9cfe4716ef32
    Closes-Bug: 1693788

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ironic 9.2.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/523943

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/524310

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/524599

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/524729

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/523943
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=97a8ae1c7765aae06b86162b3191186b14f1c8c6
Submitter: Zuul
Branch: master

commit 97a8ae1c7765aae06b86162b3191186b14f1c8c6
Author: Hugo Nicodemos <email address hidden>
Date: Wed Nov 29 14:26:13 2017 -0300

    Introduce hpOneView and ilorest to OneView

    It introduces the ``hpOneView`` and ``ilorest`` library to the
    OneView Driver. This patch will be used as the standard patch to
    other patches related to the removal of the ``python-oneviewclient``
    library dependency.

    Change-Id: Ib9d72ff5713d58631bcdccc817707b5d512e156e
    Partial-Bug: #1693788
    Co-Authored-By: Fellype Cavalcante <email address hidden>
    Co-Authored-By: Ricardo Araujo <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/524310
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=c6b615cc5b591af607f95eb9c25bdb409f708fb6
Submitter: Zuul
Branch: master

commit c6b615cc5b591af607f95eb9c25bdb409f708fb6
Author: Fellype Cavalcante <email address hidden>
Date: Thu Nov 30 15:14:52 2017 -0300

    Migrate oneview hardware type to use python-hpOneView

    Migrate the code on ``oneview`` hardware type to stop using
    ``python-oneviewclient`` in order to use ``python-hpOneView``
    and ``python-ilorest-library``. The library ``python-hpOneView``
    is more recent and is being more actively developed and maintained.

    Co-Authored-By: Hugo Nicodemos <email address hidden>
    Co-Authored-By: Xavier <email address hidden>

    Change-Id: I2c5b1703603b1401be637b6172cc4297f705332f
    Partial-Bug: #1693788

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/524599
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=b1aa04481faa0c08a3fe57500d4433c28af02107
Submitter: Zuul
Branch: master

commit b1aa04481faa0c08a3fe57500d4433c28af02107
Author: Hugo Nicodemos <email address hidden>
Date: Fri Dec 1 10:33:03 2017 -0300

    Migrate python-oneviewclient validations to oneview hardware type

    As part of the process to stop the use of ``python-oneviewclient``
    in favor of ``python-hpOneView`` and ``python-ilorest-library``, the
    validations of the ``python-oneviewclient`` have to be migrated to
    the ``oneview`` hardware type.

    Change-Id: I9031f6e9a59901d3241c6802938252bb63cfe6ca
    Partial-Bug: #1693788

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/524729
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=f8bf0ad51b3acd97832f999b8f3744266c345670
Submitter: Zuul
Branch: master

commit f8bf0ad51b3acd97832f999b8f3744266c345670
Author: Hugo Nicodemos <email address hidden>
Date: Fri Dec 1 17:58:11 2017 -0300

    Remove python-oneviewclient from oneview hardware type.

    This patch removes the ``python-oneviewclient`` library from
    ``oneview`` hardware type since it was migrated to ``hponeview``
    and ``python-ilorest-library``.

    Change-Id: I3393189abdff6a0e56f54375877cc310d72ff5b1
    Closes-Bug: #1693788

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/539237

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/539237
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=c924a374c4467ab347858c17563ac7a6d3767271
Submitter: Zuul
Branch: master

commit c924a374c4467ab347858c17563ac7a6d3767271
Author: Hugo Nicodemos <email address hidden>
Date: Tue Jan 30 12:15:10 2018 -0300

    Follow-up for Switch OneView driver to hpOneView and ilorest libraries

    This patch addresses comments for patchs related to
    bug #1693788

    Change-Id: I1fbab4674050bfbd94882c65686881867b100191
    Related-Bug: 1693788

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ironic 10.1.0 release.