[RFE] Make ip address of socat console configurable

[Kaifeng Wang]

Socat console is provided to nova as a compatible serial shell. Normally, nova serial proxy communicate with socat service, which is hosted at ironic conductor, within the management network.

However, the ip address binded by socat is only configurable by $my_ip, which is also used by other service such as tftp server. Now ironic supports vlan, the management network is usually not the same as provision network (where there tftp server residents).

This rfe is proposed to make the ip address of socat console configurable, by introducing a new option [console]/socat_address. For backward compatibility, the default value is set to $my_ip.

Socat binding address will be decoupled with the more generic $my_ip option after this patch.

[Julia Kreger (juliaashleykreger)]

This seems logical to me in order to enable complex deployments, as well as a relatively simple change.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/473201

[Ruby Loo (rloo)]

I'm good with the idea, i just wish I wouldn't have to look at the actual code patch to see what the new config option name is, what it's default value is...

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/473201
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=3901e0b9217d8c5fe6b7f8c45c98ae1db8e4afb0
Submitter: Jenkins
Branch: master

commit 3901e0b9217d8c5fe6b7f8c45c98ae1db8e4afb0
Author: wangkf <email address hidden>
Date: Mon Jun 12 11:29:32 2017 +0800

    Make IP address of socat console configurable

    When ironic supports VLAN, the management network is usually not
    the same as provision network, where TFTP server resides.

    This patch adds a new configuration for socat address, namely
    [console]/socat_address, and defaults to $my_ip for backward
    compatibility.

    Change-Id: I329a1707c74dc187d890231376e8ddf9eb36390b
    Closes-Bug: #1691344

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ironic 9.0.0 release.