[RFE] deprecate continue_node_clean() RPC API method

Bug #1688489 reported by Yuriy Zveryanskyy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Invalid
Wishlist
Unassigned

Bug Description

continue_node_clean() in ironic tree used only in IPA driver for async cleaning. In rpcapi version 1.27 this method has been converted to cast, due to slow performance of cleaning many nodes at the same time. The main problem is - we can not to do exceptions handling with rpc cast on the caller side. Proposed changes: Deprecate this method. Switch IPA driver to direct calling of this method. For example one of solution: on the start (or init) conductor manager assign own instance to "private" base interface class variable (we use one manager instance per process). Add continue_node_clean() method to deploy interface with simple default implementation. Remove continue_node_clean() from RPC API after deprecation period.

Tags: needs-spec rfe
tags: added: rfe
Revision history for this message
Julia Kreger (juliaashleykreger) wrote :

I kind of feel like I would have to see a proof of concept of the implementation to wrap my head around this right now, at least right now without coffee on my brain. I kind of think it would be viable, although I suspect we would need to pull a long deprecation period.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to ironic (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/463303

Dmitry Tantsur (divius)
Changed in ironic:
status: New → Confirmed
importance: Undecided → Wishlist
Revision history for this message
Dmitry Tantsur (divius) wrote :

On the meeting today we've decided this needs a spec.

tags: added: needs-spec
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to ironic-specs (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/492948

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ironic-specs (master)

Change abandoned by "Dmitry Tantsur <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/ironic-specs/+/492948
Reason: While I agree that we should remove the RPC methos, 1) the deploy steps work has made the proposed solution obsolete, 2) I don't think we need a spec for that.

Changed in ironic:
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.