Introspection fails with InternalServerError not valid power interface

[Sergii Turivnyi]

Steps to reproduce:

  Create node without driver_info
  Inspect node

Actual result
  InternalServerError: Failed to inspect hardware. Reason: Failed to validate inspection or power info. Error: Missing the following IPMI credentials in node's driver_info: ['ipmi_address']. (HTTP 500)

Expected result
  (HTTP 400)

Trace:
  http://paste.openstack.org/show/608104/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/461036

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/461036
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=3bda561e318e0172d6209f1580340ed9a04a161d
Submitter: Jenkins
Branch: master

commit 3bda561e318e0172d6209f1580340ed9a04a161d
Author: Galyna Zholtkevych <email address hidden>
Date: Fri Apr 28 16:38:33 2017 +0300

    Raise HTTP 400 rather than 500 error

    Currently conductor method inspecting hardware
    raises HardwareInspectionFailure with 500 Internal Error
    if driver.power.validate fail (e.g. , ``driver_info`` is
    not provided or some fields are missing).

    Since this is an apparent client error, an HTTP error code
    400-Bad request is more appropriate.
    The validation method actually raises this needed error
    and catching this is not needed anymore.

    Change-Id: I080dedeac7ce33135fde8c53494e618ccf07c941
    Closes-Bug: #1686457

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/482165

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/482165
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=0085339b1658b2b1974c6eccbf21b4e4a58fc61c
Submitter: Jenkins
Branch: master

commit 0085339b1658b2b1974c6eccbf21b4e4a58fc61c
Author: Ruby Loo <email address hidden>
Date: Mon Jul 10 10:44:57 2017 -0400

    [reno] Clarify fix for inspect validation failures

    This updates the reno for 3bda561e318e0172d6209f1580340ed9a04a161d
    to clarify what was being fixed (returning HTTP 400 instead of
    HTTP 500).

    Change-Id: I412b650a22af3fdbaa92771c66eb37f3c07b7243
    Related-Bug: #1686457

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ironic 9.0.0 release.