Disk identifier overwritten by parted

Bug #1685093 reported by Jacek Tomasiak
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Undecided
Jacek Tomasiak

Bug Description

When using a whole disk image with ID of 0x00000000, parted call inside config drive creation sets the ID to non-zero value. The original ID is written to pxelinux.cfg/* config and the machine fails to boot.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/458740

Changed in ironic:
assignee: nobody → Jacek Tomasiak (skazi)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/458740
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=cbc29a9b7b78eafa830e2752e2c7f43604917259
Submitter: Jenkins
Branch: master

commit cbc29a9b7b78eafa830e2752e2c7f43604917259
Author: Jacek Tomasiak <email address hidden>
Date: Fri Apr 21 08:56:25 2017 +0200

    Read disk identifier after config drive setup

    If original disk image has ID of 0x00000000 it's overwritten by parted
    with a non-zero value. The original ID is stored in pxelinux.cfg/* config
    file and the node fails to boot.

    Reading the ID was moved to after config drive setup so that the final ID
    is returned.

    Change-Id: Icbfa3e93bf6252177a0baa5f89bf4565ff331520
    Closes-Bug: #1685093

Changed in ironic:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/460418

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/460420

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (stable/ocata)

Reviewed: https://review.openstack.org/460418
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=451251def7aa5fc2cf9cabdde2d73e52d5dbb3a6
Submitter: Jenkins
Branch: stable/ocata

commit 451251def7aa5fc2cf9cabdde2d73e52d5dbb3a6
Author: Jacek Tomasiak <email address hidden>
Date: Fri Apr 21 08:56:25 2017 +0200

    Read disk identifier after config drive setup

    If original disk image has ID of 0x00000000 it's overwritten by parted
    with a non-zero value. The original ID is stored in pxelinux.cfg/* config
    file and the node fails to boot.

    Reading the ID was moved to after config drive setup so that the final ID
    is returned.

    Change-Id: Icbfa3e93bf6252177a0baa5f89bf4565ff331520
    Closes-Bug: #1685093
    (cherry picked from commit cbc29a9b7b78eafa830e2752e2c7f43604917259)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (stable/newton)

Reviewed: https://review.openstack.org/460420
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=dd9c4d6186a953928ffa75b7ccd21a2cb32a5e6e
Submitter: Jenkins
Branch: stable/newton

commit dd9c4d6186a953928ffa75b7ccd21a2cb32a5e6e
Author: Jacek Tomasiak <email address hidden>
Date: Fri Apr 21 08:56:25 2017 +0200

    Read disk identifier after config drive setup

    If original disk image has ID of 0x00000000 it's overwritten by parted
    with a non-zero value. The original ID is stored in pxelinux.cfg/* config
    file and the node fails to boot.

    Reading the ID was moved to after config drive setup so that the final ID
    is returned.

    Change-Id: Icbfa3e93bf6252177a0baa5f89bf4565ff331520
    Closes-Bug: #1685093
    (cherry picked from commit cbc29a9b7b78eafa830e2752e2c7f43604917259)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ironic 7.0.2

This issue was fixed in the openstack/ironic 7.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ironic 6.2.4

This issue was fixed in the openstack/ironic 6.2.4 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ironic 9.0.0

This issue was fixed in the openstack/ironic 9.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.