Couple of DHCP Options seem to be incorrect

[Sukhdev Kapur]

Ironic conductor sets the DHCP options as shown below. While this works, it ends up creating syslog errors in the back-end, which are kind of annoying. Upon further investigating, I find out that "setver-ip-address" is not a valid name for the option. Either we should use the option number (which is more generic and vendor agnostic) or it should be corrected to "tftp-server-address"

[{'opt_name': 'bootfile-name',
 'opt_value': 'pxelinux.0'},
 {'opt_name': 'server-ip-address',
 'opt_value': '123.123.123.456'},
 {'opt_name': 'tftp-server',
 'opt_value': '123.123.123.123'}]

[Sukhdev Kapur (sukhdev-8)]

Additionally, I noticed "tftp-server" should be "tftp-server-name".
The best solution to make it vendor agnostic is to not use the names of the options, but, the option numbers should be used.

[Julia Kreger (juliaashleykreger)]

I discussed this with Sukhdev in IRC. Pasting context from IRC.

<TheJulia> Sukhdev: Looking at https://bugs.launchpad.net/ironic/+bug/1682309, could you clarify it some with background on your neutron configuration? Nothing super specific, but trying to make sure we have enough context because we did only fairly recently learn that one can use DHCP servers besides dnsmasq with neutron.
8:25:39 PM O<openstack> Launchpad bug 1682309 in Ironic "Couple of DHCP Options seem to be incorrect" [Undecided,New]
8:26:40 PM S<Sukhdev> TheJulia : right I do not use dnsmasq - I use DHCP server

8:27:35 PM T<TheJulia> Sukhdev: Any chance we can get a sanitized neutron configuration as well as if this is the ironic ``neutron`` network_interface or if it is the ``flat`` network_interface in ironic
8:28:09 PM S<Sukhdev> TheJulia : Sure I will add to the bug
8:28:12 PM T<TheJulia> Thank you!

[Sukhdev Kapur (sukhdev-8)]

To provide additional context, I do not use Neutron dnsmasq, but, DHCP server.

Here are the option numbers for the intended options:

67 Bootfile-Name N Boot File Name [RFC2132]
66 Server-Name N TFTP Server Name [RFC2132]
150 TFTP server address [RFC5859]

Here is the ironic config that I use -
http://paste.openstack.org/show/606369/

[Launchpad Janitor (janitor)]

[Expired for Ironic because there has been no activity for 60 days.]

[Dmitry Tantsur (divius)]

Judging by https://manpages.debian.org/stretch/dnsmasq-base/dnsmasq.8.en.html, server-ip-address is a valid option for it, but I really wonder if we should use numbers indeed.. Leaving this open, as it seems valid to me.

[Harald Jensås (harald-jensas)]

Is'nt this bug already addressed by https://review.openstack.org/506173 ?

[Julia Kreger (juliaashleykreger)]

I believe it is. As such marking fix released.