[RFE] Allow inspection to discover pci devices

[Nisha Agarwal]

This RFE proposes to allow inspection(OOB and inband both) to discover pci devices and populate the data in the capabilities field. Essentially it means to implement https://github.com/openstack/ironic-inspector-specs/blob/master/specs/generic-pci-resource.rst in ironic for OOB inspection.

[Jay Faulkner (jason-oldos)]

I might suggest you combine this with 1680780 and address it in a single spec.

[Wan-yen Hsu (wanyenhsu)]

Inspector already discovers PCI devices so this RFE is to allow OOB inspection to discover the same.

[Nisha Agarwal (agarwalnisha1980)]

To add on Wanyen's comment, Inspector has the spec implemented https://github.com/openstack/ironic-inspector-specs/blob/master/specs/generic-pci-resource.rst for the PCI devices discovery. The solution now will sit in ironic instead of ironic-inspector to allow OOB inspection to do the same.

So ideally it would be like this:

1. Add a new section [pci] in ironic.conf
2. Add pci_alias example in ironic.conf under [pci] as given in https://docs.openstack.org/admin-guide/compute-pci-passthrough.html and https://github.com/openstack/ironic-inspector/blob/7fff708b2cdd61938fe1ea41303a8b71cebdba02/example.conf#L705-L714
3. The inspection returns the list of pci devices based on aliases in ironic.conf.
4. ironic updates the node.properties as node.properties.aliases = {'alias1': <count>, 'alias2': <count>}
5. This can be used from nova by extending the nova.conf as given in https://docs.openstack.org/admin-guide/compute-pci-passthrough.html and adding PciPassthroughFilter to "baremetal_enabled_filters" variable in nova.conf.

Given above explanation does this require any spec?

[Nisha Agarwal (agarwalnisha1980)]

Since inspector already adds it in capabilities field, it should be fine for OOB inspection to add the pci data to capabilities insted of any other field. It will essentially follow the same spec as implemented in inspector. https://github.com/openstack/ironic-inspector-specs/blob/master/specs/generic-pci-resource.rst

SO ideally it would be like this:
1. Add a new section [pci] in ironic.conf
2. Add pci_alias example in ironic.conf under [pci] as given in https://docs.openstack.org/admin-guide/compute-pci-passthrough.html and https://github.com/openstack/ironic-inspector/blob/7fff708b2cdd61938fe1ea41303a8b71cebdba02/example.conf#L705-L714
3. The inspection returns the list of pci devices based on aliases in ironic.conf.
4. ironic updates the node.properties as node.properties.capabilities = "alias1:count1,alias2:count2"

[milan k (vetrisko)]

Adding transcripts from the meeting: http://eavesdrop.openstack.org/irclogs/%23openstack-meeting-3/%23openstack-meeting-3.2017-06-12.log.html#t2017-06-12T17:54:31

[milan k (vetrisko)]

IMO a spec is required to discuss how ironic vs inspector PCI-alias mapping should be shared.
So far 2 options were suggested that deserve more detailed description:
* extend the API of the inspector to contain the mapping
* let the ironic's inspector inspection interface post-process the mapping

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/475648

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Dmitry Tantsur <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/ironic-specs/+/475648
Reason: Abandoning because of inactivity.