If provisioning network is changed, Ironic conductor does not behave correctly

Bug #1679260 reported by Sukhdev Kapur
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
High
Sam Betts

Bug Description

During multi-tenancy testing, I discovered an undesirable behavior.

In /etc/ironic/ironic.conf, I specify the provisioning and cleaning networks by name so that I do not have to deal with the UUIDs - to make the scripts work better.

The config looks like :
[neutron]
cleaning_network = ironic-provision
provisioning_network = ironic-provision

This all works fine, except, if I delete the provisioning network and recreate it, Ir-cond remembers the old network's UUID and tries to create ports on old network which is rejected by Neutron, and hence, all BM deploy operations will fail. Instead of remembering the network UUID, conductor should read the config variable for provisioning (and cleaning networks).

The work around is restart ir-cond - which is kind of annoying.

Tags: conductor
M V P Nitesh (m-nitesh)
Changed in ironic:
assignee: nobody → M V P Nitesh (m-nitesh)
Changed in ironic:
importance: Undecided → High
status: New → Triaged
Revision history for this message
Sam Betts (sambetts) wrote :

This is caused by the conductor caching the neutron network uuid after pulling it from neutron, I think we should fix this by removing the is not None check in these functions:

https://github.com/openstack/ironic/blob/master/ironic/common/neutron.py#L427

Revision history for this message
Jay Faulkner (jason-oldos) wrote :

Seems like we're caching cleaning_network and provisioning_network too aggressively. From a short chat in IRC with pas-ha and sambetts, the expectation is for these to be dynamic so this is a high bug.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/462931

Changed in ironic:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ironic (master)

Change abandoned by Ruby Loo (<email address hidden>) on branch: master
Review: https://review.openstack.org/462931
Reason: Not needed since it was fixed by 78e689e5390acf0d18b433c05495628012466c61

Revision history for this message
Ruby Loo (rloo) wrote :

Fixed by https://review.openstack.org/#/c/537944/ (78e689e5390acf0d18b433c05495628012466c61)

Changed in ironic:
status: In Progress → Fix Released
assignee: M V P Nitesh (m-nitesh) → Sam Betts (sambetts)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.