Setting the node's properties/boot_mode capability should NOT take effect unless it matches the flavor

[Lucas Alvares Gomes]

Currently the get_boot_mode_for_deploy() method from the ironic/drivers/modules/deploy_utils.py module returns the boot mode based on what is set in the node's properties/capabilities first which is the wrong behavior.

The way it should work is: The node's properties/capabilities exposes what the node is capable of without affecting the node at all. If that capability is then match against a capability in the nova flavor it gets written to the node's instance_info/capability field which then should be used by the drivers to configure the node accordingly.

Current only the "boot_mode" capability behaves that way, all others should be fine [0]

[0] I believe the reason for this behavior is because when using ipmitool we are not able to change the boot mode on-the-fly (for some hardwares), so it needs to be configured with the correct boot mode prior to the deployment. But, even if that's true, this is a problem with one driver in specific and should not be the behavior for all other drivers that are capable of doing better.

[Dmitry Tantsur (divius)]

Fixed at some point.