Agent based deploy do not call clean_up_instance when node is deleted

[Shivanand Tendulker]

Agent based deploy do not call task.driver.boot.clean_up_instance(task) during node deletion unlike iscsi based deploy

https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/iscsi_deploy.py#L509-L521

https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/agent.py#L444-L463

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/450146

[Vladyslav Drok (vdrok)]

Hm, so as we already support netboot with agent driver, yeah, we need to clean up the pxe env too.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/450146
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=ef9300cb5995348ed70afcd0a626f81371dd4b75
Submitter: Jenkins
Branch: master

commit ef9300cb5995348ed70afcd0a626f81371dd4b75
Author: Shivanand Tendulker <email address hidden>
Date: Mon Mar 27 06:15:02 2017 -0400

    Call clean_up_instance() during node teardown for Agent deploy

    Agent based deploy do not call boot.clean_up_instance() during node
    teardown. This is required so that instance clean up can happen as
    part of node teardown.

    Change-Id: I6077b69f17ce462b6aae1b16fdb40158cf111c5e
    Closes-Bug: #1676321

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ironic 8.0.0 release.