Add functional tests for Attach/Detach VIF in ironic tempest plugin

[Kyrylo Romanenko]

Add functional tests for Attach/Detach VIF in ironic tempest plugin

[Kyrylo Romanenko (kromanenko)]

Positive tests: https://review.openstack.org/#/c/436003/
Negative tests: https://review.openstack.org/#/c/435952/

[Vladyslav Drok (vdrok)]

I'd prefer using the bug which was describing the actual feature instead of introducing new ones, but well, they're here already...

[Ruby Loo (rloo)]

I agree with vdrok

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/436003
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=7359c360e5b1d45b627d213a11f937f4ed860583
Submitter: Jenkins
Branch: master

commit 7359c360e5b1d45b627d213a11f937f4ed860583
Author: Kyrylo Romanenko <email address hidden>
Date: Mon Feb 20 15:55:23 2017 +0200

    Extend tests and checks for node VIFs

    Add more checks to the test_vifs test:
      - check that attached VIF appears in port internal_info;
      - check that VIF was detached and does not appear in
        node's VIF list anymore.
    Add test for VIF attachement to node with portgroup.

    Partial-Bug: #1666534
    Change-Id: I755df18e03d01fe93f85df114b979ea7ea70ca53

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/489796

[OpenStack Infra (hudson-openstack)]

Change abandoned by John L. Villalovos (<email address hidden>) on branch: master
Review: https://review.openstack.org/489796
Reason: Will work with infra to do a batch upload.

[Iury Gregory Melo Ferreira (iurygregory)]

Seems like one of the patches got merged, so I will assume we fixed this bug. (Since is quite old - 2017...)

[Kyrylo Romanenko (kromanenko)]

It seems I have some time now to complete the 2nd patch as well :)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/906078
Committed: https://opendev.org/openstack/ironic-tempest-plugin/commit/95b901c3ffa7f758011c5d3a4ecca5c45dc3da60
Submitter: "Zuul (22348)"
Branch: master

commit 95b901c3ffa7f758011c5d3a4ecca5c45dc3da60
Author: Kyrylo Romanenko <email address hidden>
Date: Fri Jan 19 05:24:44 2024 +0400

    Add negative tests for VIF attach/detach operations

    Add tests:
      test_vif_already_attached_on_internal_info
      test_vif_already_attached_with_portgroups
      test_vif_attach_no_free_port
      test_vif_attach_no_port
      test_vif_attach_with_empty_portgroup
      test_vif_attach_port_not_in_portgroup
      test_vif_attach_node_doesnt_exist
      test_vif_attach_no_args
      test_vif_detach_not_existing
      test_vif_detach_no_args

    Closes-Bug: #1666534
    Change-Id: I657fbecd37ceec424da6182507f324b653288857

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Kyrylo Romanenko <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/ironic/+/435952
Reason: Complete in new PS in a separate repository for the ironic tempest plugin.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ironic-tempest-plugin 2.8.0 release.