Ironic conductor does not validate ipmi_address URLs

[M V P Nitesh]

When user does "ironic node-validate <node-uuid>", ironic conductor does not validate the ipv4 address. The ip address entered by the user should be a valid ip address. At the time of node-updation, characters are accepted as part of ip-address and when user does the node-validation it succeeds.

[Vladyslav Drok (vdrok)]

What do you mean by ipv4 address? The node does not have an ip address field. Please add more information about the issue.

[Michael Turek (mjturek)]

Hello m-nitesh:

Are you referring to validation of the BMC/HMC address? (ie - for the agent_ipmitool driver this would be the 'ipmi_address')

Or maybe the agent_url?

Either way these are not necessarily IPs. I'd like some more info.

[M V P Nitesh (m-nitesh)]

Hi Michael Turek:

I'm referring to ipmi_address which updated in the node. Suppose if we add ipmi_address as "123.233.342.123"(which is not a valid IP address) or "dfk-dfkl_kdfs.com"(which is not a valid host name) when the user does "ironic node-validate <node-name>" it should throw error stating user has updated the invalid ipmi_address

[Seamanhanshan (yaojun)]

hello MVPN, just as we talked in IRC, i'll assign this bug to me, thanks!

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/465866

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Dmitry Tantsur <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/ironic/+/465866
Reason: Abandoning because of inactivity