Ironic

Impossible to detach VIF when it was manually attached to port in portgroup

Bug #1663660 reported by Kyrylo Romanenko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Medium
Vasyl Saienko

Bug Description

Got VIF not attached when doing ironic node-vif-detach <node> vif when port is in portgroup and VIF was manually attached by ironic port-update add <port> extra/vif_port_id=VIF

Steps to reproduce:
1) Create a node.
2) Create a port for the node.
3) Create a portgroup for the node.
4) Add port to the portgroup.
5) Manually attach VIF to a port. ironic port-update add <port> extra/vif_port_id=VIF
6) Try to detach VIF from node by using ironic node-vif-detach <node> VIF

See original description
Vasyl Saienko (vsaienko)
Changed in ironic:
assignee: nobody → Vasyl Saienko (vsaienko)
Kyrylo Romanenko (kromanenko)
Changed in ironic:
status: New → Invalid
Revision history for this message
Kyrylo Romanenko (kromanenko) wrote :

Need to recheck this bug on fresher Devstack from master.

Changed in ironic:
status: Invalid → Incomplete
Vasyl Saienko (vsaienko)
summary: - 'tenant_vif_port_id' field does not get into port-group internal_info
+ Impossible to detach VIF when it was manually attached to port in
+ portgroup
description: updated
Changed in ironic:
status: Incomplete → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/432995

Changed in ironic:
status: Confirmed → In Progress
Dmitry Tantsur (divius)
Changed in ironic:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/432995
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=a951e452e14b37d7ea25a90e5ec2bfe6bd64b105
Submitter: Jenkins
Branch: master

commit a951e452e14b37d7ea25a90e5ec2bfe6bd64b105
Author: Vasyl Saienko <email address hidden>
Date: Mon Feb 13 13:11:27 2017 +0200

    Walk over all objects when doing VIF detach

    We apply specific rules when doing VIF attach, do not duplicate them
    in vif_detach just walk over all port and portgroup objects.
    This also fixes an issue when VIF was attached to port manually
    (set vif_port_id key in port.extra) and it is impossible to detach
    such VIF via v1/nodes/<node_ident>/vifs API.

    Closes-Bug: #1663660

    Change-Id: I70fe87bb4ae15a506fec705d10beaed572c0b45e

Changed in ironic:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ironic 7.0.0

This issue was fixed in the openstack/ironic 7.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.