Ironic

API sample generator script isn't idempotent

Bug #1662326 reported by Mario Villaplana
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Low
Julia Kreger

Bug Description

ironic/api-ref/regenerate-samples.sh, which is used to generate samples for the API reference, isn't idempotent. It creates a node named "test_node" but doesn't delete it after finishing updates of the API sample files (or on error).

This causes regenerate-samples.sh to fail until the operator deletes the devstack node from ironic manually.

Step to reproduce: Try running regenerate-samples.sh twice.

Mario Villaplana (mario-villaplana-j)
Changed in ironic:
assignee: nobody → Mario Villaplana (mario-villaplana-j)
Vladyslav Drok (vdrok)
Changed in ironic:
status: New → Confirmed
importance: Undecided → Low
status: Confirmed → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/ironic/+/907638

Changed in ironic:
status: Triaged → In Progress
Julia Kreger (juliaashleykreger)
Changed in ironic:
assignee: Mario Villaplana (mario-villaplana-j) → Julia Kreger (juliaashleykreger)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.opendev.org/c/openstack/ironic/+/907638
Committed: https://opendev.org/openstack/ironic/commit/8b79a20d7b9d3947b3ea2ee2e48ad5b7666efcd7
Submitter: "Zuul (22348)"
Branch: master

commit 8b79a20d7b9d3947b3ea2ee2e48ad5b7666efcd7
Author: Julia Kreger <email address hidden>
Date: Fri Feb 2 16:38:41 2024 -0800

    trivial: fix api-ref generation script

    A long time ago, Mario filed a BZ. But nobody fixed it.

    It was an easy fix, and I've done it here.

    Closes-Bug: 1662326
    Change-Id: I89d4fd9dd93950ff59419c913fe292de17b112e7

Changed in ironic:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ironic 24.1.0

This issue was fixed in the openstack/ironic 24.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.