Check sort key to see if it is an allowed field

Bug #1659419 reported by Ruby Loo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Low
Ruby Loo

Bug Description

We aren't checking the value for the sort key in a node-list operation. We allow to sort on a field even if that field is not available in the specified API version.

Dmitry Tantsur (divius)
summary: - should check sort key to see if it is an allowed field
+ Check sort key to see if it is an allowed field
Changed in ironic:
status: New → Triaged
Changed in ironic:
status: Triaged → In Progress
Revision history for this message
Ruby Loo (rloo) wrote :

patch submitted to address this: https://review.openstack.org/#/c/461592/

Revision history for this message
Ruby Loo (rloo) wrote :

The patch addresses sort key when getting lists for node, port groups, and ports. (It wasn't needed for chassis since it doesn't have any new fields guarded by API microversions.)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/461592
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=db0c42a95599955b27624429f16ea9f73860729e
Submitter: Jenkins
Branch: master

commit db0c42a95599955b27624429f16ea9f73860729e
Author: Ruby Loo <email address hidden>
Date: Tue May 2 02:18:08 2017 +0000

    Check if sort key is allowed in API version

    This checks the sort key, to make sure the specified field
    is allowed/available in the specified API microversion.
    If it is not allowed, a 406 HTTP status is returned.

    This affects requests to get lists of nodes, port groups,
    and ports.

    Change-Id: Id5fb44b8b7fe989514dbae4b60cef4a34d47e52b
    Closes-Bug: #1659419

Changed in ironic:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ironic 9.0.0

This issue was fixed in the openstack/ironic 9.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.