No way to abort even abortable in-band manual cleaning step

Bug #1658061 reported by Dmitry Tantsur
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
High
Dmitry Tantsur

Bug Description

I'd want to abort shredding hard drive, but I can't. The node is stuck in "clean wait". I've tried:
1. node-set-provision-state abort (nothing happens)
2. restarting ironic-conductor (ditto)
3. node-set-provision-state abort (fails as expected).

The current cleaning state (it's been stuck for 10 days already):

| driver_internal_info | {u'clean_step_index': 0, u'agent_cached_clean_steps_refreshed': u'2017-01-10 12:11:41.165824', u'agent_cached_clean_steps': {u'deploy': |
| | [{u'priority': 99, u'interface': u'deploy', u'reboot_requested': False, u'abortable': True, u'step': u'erase_devices_metadata'}, {u'priority': |
| | 10, u'interface': u'deploy', u'reboot_requested': False, u'abortable': True, u'step': u'erase_devices'}]}, u'clean_steps': [{u'interface': |
| | u'deploy', u'step': u'erase_devices'}], u'hardware_manager_version': {u'generic_hardware_manager': u'1.1'}, |
| | u'agent_continue_if_ata_erase_failed': False, u'agent_erase_devices_iterations': 1, u'agent_erase_devices_zeroize': True, u'agent_url': |
| | u'http://192.168.24.8:9999'}

Revision history for this message
Dmitry Tantsur (divius) wrote :

Found in logs:

 The current clean step "erase_devices" for node 5983b961-2c47-4c9b-962b-0a9dfc194c86 is not abortable

This contradicts whatever we have in IPA for it.

Revision history for this message
Dmitry Tantsur (divius) wrote :

Indeed, while the clean step is abortable, node.clean_step does not have this information:

| clean_step | {u'interface': u'deploy', u'step': u'erase_devices', u'abort_after': True}

Dmitry Tantsur (divius)
summary: - No way to abort even abortable in-band cleaning step
+ No way to abort even abortable in-band manual cleaning step
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/423235

Changed in ironic:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/423235
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=ee6bfb3ac921c292ac4e60af732f8ef4bf45496c
Submitter: Jenkins
Branch: master

commit ee6bfb3ac921c292ac4e60af732f8ef4bf45496c
Author: Dmitry Tantsur <email address hidden>
Date: Fri Jan 20 13:11:12 2017 +0100

    Correctly cache "abortable" flag for manual clean steps

    Currently we don't store it, thus all clean steps are considered not
    abortable. Also cache "priority" in case something relies on it.

    Change-Id: I9e30925113711456ff4d9e5f1c00d60af78a45ff
    Closes-Bug: #1658061

Changed in ironic:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ironic 7.0.0

This issue was fixed in the openstack/ironic 7.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.