Validation that local_link_connection is present is missed for nodes with network_interface=neutron

[Vasyl Saienko]

If local_link_connection information is missed and node have neutron network_interface deployment will fail with DEPLOY WAIT timeout as Ironic doesn't check neutron port status, and Neutron port will remain unbound or in ERROR state, because ML2 drivers required local_link_connection to be passed.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/415881

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/415881
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=56570b1f41e84f40ea18f534217fc8b093ce6e9a
Submitter: Jenkins
Branch: master

commit 56570b1f41e84f40ea18f534217fc8b093ce6e9a
Author: Vasyl Saienko <email address hidden>
Date: Fri Dec 30 15:53:41 2016 +0200

    Validate port info before assume we may use it

    Ironic 'neutron' network driver requires local_link_connection to be
    present on ironic port to be able to work with it (plug to specific
    network).
    This patch ignores ironic ports without local_link_connection when
    attaching VIF to node with 'neutron' network driver.
    Also make sure that we do not pick such port for provisioning and
    cleaning.

    Closes-Bug: #1653249

    Change-Id: Icb8298b9be0d8ba62192580263feafa0e1708129

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ironic 7.0.0 release.