Enabling debug in Ironic should also enable it for IPA

[Lucas Alvares Gomes]

Today, when you set the "[DEFAULT]/debug" configuration option to True it only affects Ironic. I believe that, being IPA an extension of the code running in-band on the node this option should also affect it. Right now, in order to enable debug in IPA one needs to append "ipa-debug=1" at the "[pxe]/pxe_append_params" configuration option.

I suggest that, the code generating the PXE configuration files should check if CONF.debug is True and also if there's no explicit mention of "ipa-debug" in the CONF.pxe.pxe_append_params* and if so, Ironic itself should append the "ipa-debug=1" value to enabled debug in the system as a whole using one single option.

* To not overwrite what the user specified

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/410168

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/410168
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=f13f1ed654042daa405d8e92f03ddfca40d18d08
Submitter: Jenkins
Branch: master

commit f13f1ed654042daa405d8e92f03ddfca40d18d08
Author: Lucas Alvares Gomes <email address hidden>
Date: Tue Dec 13 11:08:49 2016 +0000

    Make CONF.debug also reflect on IPA

    Prior to this patch, setting the CONF.debug to True in the ironic.conf
    doesn't enable the debug logs in IPA. The user had to also append
    "ipa-debug=1" to the CONF.pxe.pxe_append_params configuration option.

    This patch is changing this behavior by making the CONF.debug option
    reflect on the IPA logs as well. As I understand, IPA is just an
    extension of the Ironic code that runs in-band on the node allowing
    Ironic to access the local hardware. This way, in order to enable debug
    as a whole the user only needs to set one configuration option.

    The code in this patch checks if CONF.debug is set to True and also
    check if "ipa-debug" is not explicit set in CONF.pxe.pxe_append_params
    configuration - to not overwrite the user configuration - and only then
    will append "ipa-debug=1" to it.

    The "ipa-debug=1" kernel parameter was also removed from the devstack
    lib because CONF.debug is always set to True there.

    Change-Id: I675fb11248d3789d45cf5905b7c15368f026b345
    Closes-Bug: #1649561

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ironic 7.0.0 release.