Ironic API service does not start with default audit.ignore_req_list conf option

Bug #1648387 reported by Yuriy Zveryanskyy
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Medium
Yuriy Zveryanskyy

Bug Description

If we do not want ignore any HTTP method in audit middleware default None value causes error:

2016-12-08 09:55:23.403 TRACE ironic Traceback (most recent call last):
2016-12-08 09:55:23.403 TRACE ironic File "/usr/local/bin/ironic-api", line 10, in <module>
2016-12-08 09:55:23.403 TRACE ironic sys.exit(main())
2016-12-08 09:55:23.403 TRACE ironic File "/opt/stack/ironic/ironic/cmd/api.py", line 42, in main
2016-12-08 09:55:23.403 TRACE ironic server = wsgi_service.WSGIService('ironic_api', CONF.api.enable_ssl_api)
2016-12-08 09:55:23.403 TRACE ironic File "/opt/stack/ironic/ironic/common/wsgi_service.py", line 37, in __init__
2016-12-08 09:55:23.403 TRACE ironic self.app = app.VersionSelectorApplication()
2016-12-08 09:55:23.403 TRACE ironic File "/opt/stack/ironic/ironic/api/app.py", line 98, in __init__
2016-12-08 09:55:23.403 TRACE ironic self.v1 = setup_app(pecan_config=pc)
2016-12-08 09:55:23.403 TRACE ironic File "/opt/stack/ironic/ironic/api/app.py", line 67, in setup_app
2016-12-08 09:55:23.403 TRACE ironic ignore_req_list=CONF.audit.ignore_req_list
2016-12-08 09:55:23.403 TRACE ironic File "/usr/local/lib/python2.7/dist-packages/keystonemiddleware/audit/__init__.py", line 95, in __init__
2016-12-08 09:55:23.403 TRACE ironic conf.get('ignore_req_list', '').split(',')]
2016-12-08 09:55:23.403 TRACE ironic AttributeError: 'NoneType' object has no attribute 'split'

Changed in ironic:
assignee: nobody → Yuriy Zveryanskyy (yzveryanskyy)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/408572

Changed in ironic:
status: New → In Progress
Changed in ironic:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/408572
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=8bcee6e20656656963bb4e546e552aeeaee9be90
Submitter: Jenkins
Branch: master

commit 8bcee6e20656656963bb4e546e552aeeaee9be90
Author: Yuriy Zveryanskyy <email address hidden>
Date: Thu Dec 8 13:19:00 2016 +0200

    Fix default value of "ignore_req_list" config option

    If audit is enabled ironic API service does not start with default
    value (None) of "ignore_req_list" config option. This patch changes
    default value to empty string. Related modification added to ironic
    sample config.

    Closes-Bug: 1648387
    Change-Id: Ifbbbed4012670b4b05fcf63e5586024f3c927875

Changed in ironic:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ironic 7.0.0

This issue was fixed in the openstack/ironic 7.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.