| 2016-11-09 17:03:16 |
Vladyslav Drok |
bug |
|
|
added bug |
| 2016-11-09 17:03:54 |
Vladyslav Drok |
ironic: importance |
Undecided |
Wishlist |
|
| 2016-11-09 17:04:06 |
Vladyslav Drok |
ironic: assignee |
|
Vladyslav Drok (vdrok) |
|
| 2016-11-09 17:04:24 |
Vladyslav Drok |
tags |
|
rfe |
|
| 2016-11-09 17:52:16 |
Vladyslav Drok |
description |
Right now, the following request succeeds:
curl -i -X GET -H 'X-OpenStack-Ironic-API-Version: latest' -H 'Content-Type: application/json' -H 'X-Auth-Token: ***' http://127.0.0.1:6385/v1/nodes/node-0/driver_info
HTTP/1.1 200 OK
X-Openstack-Ironic-Api-Minimum-Version: 1.1
X-Openstack-Ironic-Api-Maximum-Version: 1.24
X-Openstack-Ironic-Api-Version: 1.24
Content-Length: 437
Content-Type: application/json; charset=UTF-8
Openstack-Request-Id: req-5685cb9b-d030-42ea-b859-a0d202a6481c
Date: Wed, 09 Nov 2016 16:59:31 GMT
{"links": [{"href": "http://127.0.0.1:6385/v1/nodes/10d37852-f656-4f8b-94ae-b93c8921f832", "rel": "self"}, {"href": "http://127.0.0.1:6385/nodes/10d37852-f656-4f8b-94ae-b93c8921f832", "rel": "bookmark"}], "driver_info": {"ipmi_port": 6230, "ipmi_username": "admin", "deploy_kernel": "af919996-91e1-46da-a443-c1a0598d9d11", "ipmi_address": "127.0.0.1", "deploy_ramdisk": "0e362471-4870-4e23-a9ca-d0d4be9abdea", "ipmi_password": "******"}}
Trying to access an invalid field in such way returns 400:
curl -i -X GET -H 'X-OpenStack-Ironic-API-Version: latest' -H 'Content-Type: application/json' -H 'X-Auth-Token: ***' http://127.0.0.1:6385/v1/nodes/node-0/driver_in
HTTP/1.1 400 Bad Request
X-Openstack-Ironic-Api-Minimum-Version: 1.1
X-Openstack-Ironic-Api-Maximum-Version: 1.24
X-Openstack-Ironic-Api-Version: 1.24
Openstack-Request-Id: req-92dc5fa1-c7ba-4199-b50a-c2f12d216309
Content-Type: application/json
Content-Length: 132
Date: Wed, 09 Nov 2016 17:01:46 GMT
{"error_message": "{\"debuginfo\": null, \"faultcode\": \"Client\", \"faultstring\": \"Field(s) \\\"driver_in\\\" are not valid\"}"}
Everything that follows a resource identifier should be treated as a subcontroller, not a field of the resource. Being unable to find a subcontroller should return error code 404 instead of 400. |
Right now, the following request succeeds:
curl -i -X GET -H 'X-OpenStack-Ironic-API-Version: latest' -H 'Content-Type: application/json' -H 'X-Auth-Token: ***' http://127.0.0.1:6385/v1/nodes/node-0/driver_info
HTTP/1.1 200 OK
X-Openstack-Ironic-Api-Minimum-Version: 1.1
X-Openstack-Ironic-Api-Maximum-Version: 1.24
X-Openstack-Ironic-Api-Version: 1.24
Content-Length: 437
Content-Type: application/json; charset=UTF-8
Openstack-Request-Id: req-5685cb9b-d030-42ea-b859-a0d202a6481c
Date: Wed, 09 Nov 2016 16:59:31 GMT
{"links": [{"href": "http://127.0.0.1:6385/v1/nodes/10d37852-f656-4f8b-94ae-b93c8921f832", "rel": "self"}, {"href": "http://127.0.0.1:6385/nodes/10d37852-f656-4f8b-94ae-b93c8921f832", "rel": "bookmark"}], "driver_info": {"ipmi_port": 6230, "ipmi_username": "admin", "deploy_kernel": "af919996-91e1-46da-a443-c1a0598d9d11", "ipmi_address": "127.0.0.1", "deploy_ramdisk": "0e362471-4870-4e23-a9ca-d0d4be9abdea", "ipmi_password": "******"}}
Trying to access an invalid field in such way returns 400:
curl -i -X GET -H 'X-OpenStack-Ironic-API-Version: latest' -H 'Content-Type: application/json' -H 'X-Auth-Token: ***' http://127.0.0.1:6385/v1/nodes/node-0/driver_in
HTTP/1.1 400 Bad Request
X-Openstack-Ironic-Api-Minimum-Version: 1.1
X-Openstack-Ironic-Api-Maximum-Version: 1.24
X-Openstack-Ironic-Api-Version: 1.24
Openstack-Request-Id: req-92dc5fa1-c7ba-4199-b50a-c2f12d216309
Content-Type: application/json
Content-Length: 132
Date: Wed, 09 Nov 2016 17:01:46 GMT
{"error_message": "{\"debuginfo\": null, \"faultcode\": \"Client\", \"faultstring\": \"Field(s) \\\"driver_in\\\" are not valid\"}"}
Everything that follows a resource identifier should be treated as a subcontroller, not a field of the resource. Being unable to find a subcontroller should return error code 404 instead of 400. API microversion will be bumped. |
|
| 2016-11-28 20:06:38 |
Ruby Loo |
summary |
Sub-endpoints of ironic resources should be considered subcontrollers, not fields of the resource |
[RFE] Sub-endpoints of ironic resources should be considered subcontrollers, not fields of the resource |
|
| 2016-12-05 17:39:17 |
Vladyslav Drok |
tags |
rfe |
|
|
| 2016-12-05 17:39:52 |
Vladyslav Drok |
description |
Right now, the following request succeeds:
curl -i -X GET -H 'X-OpenStack-Ironic-API-Version: latest' -H 'Content-Type: application/json' -H 'X-Auth-Token: ***' http://127.0.0.1:6385/v1/nodes/node-0/driver_info
HTTP/1.1 200 OK
X-Openstack-Ironic-Api-Minimum-Version: 1.1
X-Openstack-Ironic-Api-Maximum-Version: 1.24
X-Openstack-Ironic-Api-Version: 1.24
Content-Length: 437
Content-Type: application/json; charset=UTF-8
Openstack-Request-Id: req-5685cb9b-d030-42ea-b859-a0d202a6481c
Date: Wed, 09 Nov 2016 16:59:31 GMT
{"links": [{"href": "http://127.0.0.1:6385/v1/nodes/10d37852-f656-4f8b-94ae-b93c8921f832", "rel": "self"}, {"href": "http://127.0.0.1:6385/nodes/10d37852-f656-4f8b-94ae-b93c8921f832", "rel": "bookmark"}], "driver_info": {"ipmi_port": 6230, "ipmi_username": "admin", "deploy_kernel": "af919996-91e1-46da-a443-c1a0598d9d11", "ipmi_address": "127.0.0.1", "deploy_ramdisk": "0e362471-4870-4e23-a9ca-d0d4be9abdea", "ipmi_password": "******"}}
Trying to access an invalid field in such way returns 400:
curl -i -X GET -H 'X-OpenStack-Ironic-API-Version: latest' -H 'Content-Type: application/json' -H 'X-Auth-Token: ***' http://127.0.0.1:6385/v1/nodes/node-0/driver_in
HTTP/1.1 400 Bad Request
X-Openstack-Ironic-Api-Minimum-Version: 1.1
X-Openstack-Ironic-Api-Maximum-Version: 1.24
X-Openstack-Ironic-Api-Version: 1.24
Openstack-Request-Id: req-92dc5fa1-c7ba-4199-b50a-c2f12d216309
Content-Type: application/json
Content-Length: 132
Date: Wed, 09 Nov 2016 17:01:46 GMT
{"error_message": "{\"debuginfo\": null, \"faultcode\": \"Client\", \"faultstring\": \"Field(s) \\\"driver_in\\\" are not valid\"}"}
Everything that follows a resource identifier should be treated as a subcontroller, not a field of the resource. Being unable to find a subcontroller should return error code 404 instead of 400. API microversion will be bumped. |
Right now, the following request succeeds:
curl -i -X GET -H 'X-OpenStack-Ironic-API-Version: latest' -H 'Content-Type: application/json' -H 'X-Auth-Token: ***' http://127.0.0.1:6385/v1/nodes/node-0/driver_info
HTTP/1.1 200 OK
X-Openstack-Ironic-Api-Minimum-Version: 1.1
X-Openstack-Ironic-Api-Maximum-Version: 1.24
X-Openstack-Ironic-Api-Version: 1.24
Content-Length: 437
Content-Type: application/json; charset=UTF-8
Openstack-Request-Id: req-5685cb9b-d030-42ea-b859-a0d202a6481c
Date: Wed, 09 Nov 2016 16:59:31 GMT
{"links": [{"href": "http://127.0.0.1:6385/v1/nodes/10d37852-f656-4f8b-94ae-b93c8921f832", "rel": "self"}, {"href": "http://127.0.0.1:6385/nodes/10d37852-f656-4f8b-94ae-b93c8921f832", "rel": "bookmark"}], "driver_info": {"ipmi_port": 6230, "ipmi_username": "admin", "deploy_kernel": "af919996-91e1-46da-a443-c1a0598d9d11", "ipmi_address": "127.0.0.1", "deploy_ramdisk": "0e362471-4870-4e23-a9ca-d0d4be9abdea", "ipmi_password": "******"}}
Trying to access an invalid field in such way returns 400:
curl -i -X GET -H 'X-OpenStack-Ironic-API-Version: latest' -H 'Content-Type: application/json' -H 'X-Auth-Token: ***' http://127.0.0.1:6385/v1/nodes/node-0/driver_in
HTTP/1.1 400 Bad Request
X-Openstack-Ironic-Api-Minimum-Version: 1.1
X-Openstack-Ironic-Api-Maximum-Version: 1.24
X-Openstack-Ironic-Api-Version: 1.24
Openstack-Request-Id: req-92dc5fa1-c7ba-4199-b50a-c2f12d216309
Content-Type: application/json
Content-Length: 132
Date: Wed, 09 Nov 2016 17:01:46 GMT
{"error_message": "{\"debuginfo\": null, \"faultcode\": \"Client\", \"faultstring\": \"Field(s) \\\"driver_in\\\" are not valid\"}"}
Being unable to find a subcontroller should or a field in a resource should return error code 404 instead of 400. API microversion will be bumped. |
|
| 2016-12-05 17:44:57 |
Vladyslav Drok |
tags |
|
needs-spec rfe |
|
| 2016-12-05 18:12:41 |
Ruby Loo |
ironic: status |
New |
Triaged |
|
| 2017-01-27 14:57:08 |
OpenStack Infra |
ironic: status |
Triaged |
In Progress |
|
| 2023-04-03 16:40:56 |
Julia Kreger |
ironic: status |
In Progress |
Invalid |
|
