[RFE] Add support for DBDeadlock handling.

Bug #1639338 reported by Łukasz Leszczuk
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Wishlist
Joanna Taryma

Bug Description

Current implementation lacks proper handling of DBDeadlock exception, which is happening quite often on Galera clusters under load.

Proper DBDeadlock handling is important from stability perspective.

Tags: rfe-approved
summary: - Add support for DBDeadlock handling.
+ [RFE] Add support for DBDeadlock handling.
Revision history for this message
Grzegorz Grasza (xek) wrote :

nova does this with @oslo_db_api.wrap_db_retry(max_retries=10, retry_on_deadlock=True) on all write operations on the DB

Changed in ironic:
assignee: nobody → Grzegorz Grasza (xek)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/394413

Changed in ironic:
status: New → In Progress
Revision history for this message
Ruby Loo (rloo) wrote :

Seems like this is more of a bug than a feature, but I'm fine either way, I think this is a good idea :)

Changed in ironic:
importance: Undecided → Wishlist
tags: added: rfe-approved
Revision history for this message
Ruby Loo (rloo) wrote :
Ruby Loo (rloo)
tags: removed: rfe
Changed in ironic:
assignee: Grzegorz Grasza (xek) → Vladyslav Drok (vdrok)
Changed in ironic:
assignee: Vladyslav Drok (vdrok) → Grzegorz Grasza (xek)
Changed in ironic:
assignee: Grzegorz Grasza (xek) → Joanna Taryma (jtaryma)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/394413
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=3428cb74f0a6fe05c23cf00dc66da4c1d9766409
Submitter: Jenkins
Branch: master

commit 3428cb74f0a6fe05c23cf00dc66da4c1d9766409
Author: Joanna Taryma <email address hidden>
Date: Mon Feb 27 13:39:37 2017 -0800

    Add support for DBDeadlock handling

    Wrap all DB write operations with oslo_db decorator to retry on
    deadlock. DBDeadlock exception can be raised quite often on Galera
    clusters under load.
    This also fixes an issue which causes conductor's periodic
    tasks to stop executing.

    Closes-Bug: #1637210
    Closes-Bug: #1639338
    Co-Authored-By: Vladyslav Drok <email address hidden>
    Co-Authored-By: Joanna Taryma <email address hidden>
    Change-Id: I61db83637adfd98a5394d1f570f3de4302c93497

Changed in ironic:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ironic 8.0.0

This issue was fixed in the openstack/ironic 8.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.