Cleaning fails if conductor thread can not be started
Bug #1635619 reported by
Yuriy Zveryanskyy
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ironic |
Triaged
|
Medium
|
Unassigned |
Bug Description
We ignore exception.
summary: |
- Node stuck in the CLEANING state if worker thread can not be executed on - heartbeat + Cleaning fails if conductor thread can not be started |
description: | updated |
Changed in ironic: | |
assignee: | nobody → Joanna Taryma (jtaryma) |
Changed in ironic: | |
importance: | Undecided → Medium |
status: | New → Triaged |
To post a comment you must log in.
Pass for exception. NoFreeConductor Worker doesn't change anything, because it is never raised in agent driver. Worker is raised in conductor's continue_ node_clean, which is called via RPC cast. That means, even if continue_node_clean raises any exception, it won't get propagated to agent driver due to async communication.
NoFreeConductor
I think exception handling code should be removed as it's misleading.
Going forward - currently there is no mean for the agent to know about failure in continue_ node_clean. Similar problems may be found in other functions that communicate via RPC. Either all of that should be handled on conductor side, or we have to think about the way to inform about failures