"dhcp" command in the iPXE script is redundant and may actually break boot

[Dmitry Tantsur]

iPXE ROM does DHCP to be able to download the iPXE script, so by the time the script starts executing, the correct NIC already has an IP address. Furthermore, the "dhcp" command without arguments gets IP information for the first available interface, not necessary the PXE booting one, which can lead to unpredictable consequences.

I'm not sure why this DHCP instruction was introduced, I suggest we drop it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/389100

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/389169

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/389169
Committed: https://git.openstack.org/cgit/openstack/puppet-ironic/commit/?id=806d5a15693f7a0ce0cd379e7af81275bf334982
Submitter: Jenkins
Branch: master

commit 806d5a15693f7a0ce0cd379e7af81275bf334982
Author: Dmitry Tantsur <email address hidden>
Date: Thu Oct 20 14:45:55 2016 +0200

    Remove "dhcp" command from the iPXE script

    At this point we already have DHCP on the right NIC to be able to download
    this iPXE script. The "dhcp" may actually break the boot, as it runs DHCP
    on the first available interface, not the PXE booting one.

    Change-Id: I9ec62b6b662c9ea70f7cc12bd0567b5e4119faf7
    Closes-Bug: #1635191

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/389100
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=42b2c60ce2aeb91a9fda213cda87a22f87bb0161
Submitter: Jenkins
Branch: master

commit 42b2c60ce2aeb91a9fda213cda87a22f87bb0161
Author: Dmitry Tantsur <email address hidden>
Date: Thu Oct 20 11:59:49 2016 +0200

    Remove "dhcp" command from the iPXE template

    At this point we already have DHCP on the right NIC to be able to download
    this iPXE script. The "dhcp" may actually break the boot, as it runs DHCP
    on the first available interface, not the PXE booting one.

    Change-Id: I97dc897da49ceb8e03476ddacd5bc92dd40aa4b2
    Closes-Bug: #1635191

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/392552

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/392556

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/392556
Committed: https://git.openstack.org/cgit/openstack/puppet-ironic/commit/?id=13fda5e379719956f498d5dd998404c4f5f7b5d8
Submitter: Jenkins
Branch: stable/newton

commit 13fda5e379719956f498d5dd998404c4f5f7b5d8
Author: Dmitry Tantsur <email address hidden>
Date: Thu Oct 20 14:45:55 2016 +0200

    Remove "dhcp" command from the iPXE script

    At this point we already have DHCP on the right NIC to be able to download
    this iPXE script. The "dhcp" may actually break the boot, as it runs DHCP
    on the first available interface, not the PXE booting one.

    Change-Id: I9ec62b6b662c9ea70f7cc12bd0567b5e4119faf7
    Closes-Bug: #1635191
    (cherry picked from commit 806d5a15693f7a0ce0cd379e7af81275bf334982)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/392552
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=fa44688a9716e24f9547d1583ec99c435308da12
Submitter: Jenkins
Branch: stable/newton

commit fa44688a9716e24f9547d1583ec99c435308da12
Author: Dmitry Tantsur <email address hidden>
Date: Thu Oct 20 11:59:49 2016 +0200

    Remove "dhcp" command from the iPXE template

    At this point we already have DHCP on the right NIC to be able to download
    this iPXE script. The "dhcp" may actually break the boot, as it runs DHCP
    on the first available interface, not the PXE booting one.

    Change-Id: I97dc897da49ceb8e03476ddacd5bc92dd40aa4b2
    Closes-Bug: #1635191
    (cherry picked from commit 42b2c60ce2aeb91a9fda213cda87a22f87bb0161)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-ironic 9.4.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-ironic 10.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ironic 6.2.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-ironic 9.4.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ironic 7.0.0 release.