IscsiDeploy can leave orphaned iscsi sessions

[Pavlo Shchelokovskyy]

Discovered while debugging recent iscsi deploy failures on Xenial

Running quite a fresh (but not the latest devstack) - Ironic is w/o the fix https://review.openstack.org/#/c/384652/. Host is Ubuntu Xenial 16.04.1.

Driver is pxe_ipmitool, deploy ramdisk is tinyipa fetched from tarballs.o.o, 3 VMs are registered as BM nodes in Ironic (quite standard DevStack setup).

Deploy fails with

iSCSI connection was not seen by the file system after attempting to verify 3 times.

I have 3 nodes and automated_clean=False, all three nodes have moved to available state, Nova instance is in error

running iscsiadm shows three ISCSI sessions

$ iscsiadm -m session
tcp: [1] 10.0.0.3:3260,1 iqn.2008-10.org.openstack:61927499-32b0-475d-96d5-0f0920516ad6 (non-flash)
tcp: [2] 10.0.0.4:3260,1 iqn.2008-10.org.openstack:43e36b07-2666-4c3c-8cc3-1453e639bc92 (non-flash)
tcp: [3] 10.0.0.3:3260,1 iqn.2008-10.org.openstack:e0d1b0a1-daf3-4c0d-8e0c-83f152f6e6a3 (non-flash)

These are presumably from three attempts to deploy the nodes, but Ironic has not closed/cleaned up those sessions on deploy failure.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/388092

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/388092
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=28ccbf79c470167d17ade94497546a8d193e3995
Submitter: Jenkins
Branch: master

commit 28ccbf79c470167d17ade94497546a8d193e3995
Author: Vasyl Saienko <email address hidden>
Date: Tue Oct 18 19:07:47 2016 +0300

    Cleanup hung iscsi session

    This patch ensure that there is no iscsi session left after
    failed deployment.

    Change-Id: I569933f27746da65b1d22ba9e9279439e2e792cf
    Closes-Bug: #1632649

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ironic 8.0.0 release.