Stop local console process in multi-conductor environment

[Yuriy Zveryanskyy]

When console process is started for a node from died conductor (by operator request or automatically), and dead conductor comes back to active state, this process can not be stopped via ironic.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/431605

[Madhuri Kumari (madhuri-rai07)]

Hi Yuriy,

I tried to test this case and below is my observation:

Steps:
1. Started a console process by::

$ ironic node-set-console-mode node-0 true
$ ironic node-validate node-0
+------------+--------+---------------+
| Interface | Result | Reason |
+------------+--------+---------------+
| boot | True | |
| console | True | |
| deploy | True | |
| inspect | None | not supported |
| management | True | |
| network | True | |
| power | True | |
| raid | True | |
| storage | True | |
+------------+--------+---------------+
$ ironic node-get-console node-0
+-----------------+------------------------------------------------------------------+
| Property | Value |
+-----------------+------------------------------------------------------------------+
| console_enabled | True |
| console_info | {u'url': u'http://10.223.197.184:7777', u'type': u'shellinabox'} |
+-----------------+------------------------------------------------------------------+

2. The console process was started::

$ ps -eaf |grep shellinabox
ubuntu 75377 1 0 11:12 ? 00:00:00 shellinaboxd -t -p 7777 --background=/tmp/894fd6dc-b2c4-47bd-8054-0d46fce595cf.pid -s /:1000:1000:HOME:ipmitool -H 10.223.197.184 -I lanplus -U admin -f /tmp/894fd6dc-b2c4-47bd-8054-0d46fce595cf.pw -v sol activate
ubuntu 75378 75377 0 11:12 ? 00:00:00 shellinaboxd -t -p 7777 --background=/tmp/894fd6dc-b2c4-47bd-8054-0d46fce595cf.pid -s /:1000:1000:HOME:ipmitool -H 10.223.197.184 -I lanplus -U admin -f /tmp/894fd6dc-b2c4-47bd-8054-0d46fce595cf.pw -v sol activate
ubuntu 75533 74715 0 11:17 pts/1 00:00:00 grep --color=auto shellinabox

3. Stopped ironic-conductor service::
$ sudo systemctl ironic-conductor stop

4. Still the shellinaboxd processes were running.
5. Restarted ironic-conductor.
6. Disabled the node's console::
$ironic node-set-console-mode node-0 false

7. After this the console processes were successfully killed::
$ ps -eaf |grep shellinabox
ubuntu 77041 74715 0 12:11 pts/1 00:00:00 grep --color=auto shellinabox

$ ironic node-get-console node-0
+-----------------+-------+
| Property | Value |
+-----------------+-------+
| console_enabled | False |
| console_info | None |
+-----------------+-------+

CONCLUSION:
As per the bug report, the console process shouldn't be killed but there were killed.

Can you please check this and let me know your opinion?

Thanks,
Madhuri

[OpenStack Infra (hudson-openstack)]

Change abandoned by Julia Kreger (<email address hidden>) on branch: master
Review: https://review.opendev.org/431605
Reason: Abandoning spec as it has not been updated in nearly three years. If there is interest in it at a later time, it can be resurrected.