| 2016-09-27 14:16:33 |
Lucas Alvares Gomes |
description |
When deploying whole disk images in UEFI mode there's a check that prevents the deployment unless the boot_option capability is explicitly set to "local" (for local boot)[0]. This is not checked for non-UEFI deployment and I don't see the difference, both could be deployed w/o any problems because ironic already assumes local boot for whole disk images [1].
That said, the iLO driver seems to add yet another check [2], I don't understand the specifics of iLO so I would suggest to move this check to inside the iLO driver and have it performed only for that driver.
[0] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L220-L229
[1] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/agent.py#L338-L341
[2] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/deploy.py#L338-L346 |
When deploying whole disk images in UEFI mode there's a check that prevents the deployment unless the boot_option capability is explicitly set to "local" (for local boot)[0]. This is not checked for non-UEFI deployment and I don't see the difference, both could be deployed w/o any problems because ironic already assumes local boot for whole disk images [1].
That said, the iLO driver seems to add yet another check [2], I don't understand the specifics of iLO so I would suggest to move this check to inside the iLO driver and have it performed only for that driver.
[0] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L220-L229
[1] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/agent.py#L338-L341
[2] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/deploy.py#L338-L346
=== UPDATE ===
This seems to be triggered by an inconsistency between the agent_* drivers and the pxe_* drivers.
For agent_* drivers, when deploying a whole disk image without explicit setting the boot_option capability Ironic will assume booting from disk.
For pxe_* drivers, when deploying a whole disk image without explicit setting the boot_option capability Ironic will assume PXE boot + chainloading to the local disk. |
|
