Setting persistent boot device does not work with ipmi_force_boot_device on

[Łukasz Leszczuk]

When ipmi_force_boot_device is set and node boot order is set to pxe, after 2 reboots settings disappear from driver.

I believe the root cause is in line: https://github.com/openstack/ironic/blob/1c339b6806580719d20b303d4506c754b9c59e96/ironic/drivers/utils.py#L205. utils.set_boot_device should be called with 'persistent=true' parameter.

[Dmitry Tantsur (divius)]

How did you reboot your machine? With ipmi_force_boot_device set you are expected to use ironic or nova API to reboot it. We don't use persistent=True there, because ipmi_force_boot_device is designed to work around problems with persistent boot

[Tuan (tuanla)]

Could you provide more information to me re-proceduce bugs

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/376322

[Łukasz Leszczuk (lleszczuk)]

Dmitry,

I was using ironic API to reboot nodes.
It looks the flow looks like that:
1. utils.set_boot_device is called, with default persistent=False parameter
2. persistent parameter is passed to force_boot_device: https://github.com/openstack/ironic/blob/1c339b6806580719d20b303d4506c754b9c59e96/ironic/drivers/utils.py#L225
3. with is_next_boot_persistent is set to false
4. after next reboot the setting is removed from driver_internal_info: https://github.com/openstack/ironic/blob/1c339b6806580719d20b303d4506c754b9c59e96/ironic/drivers/utils.py#L199

[Łukasz Leszczuk (lleszczuk)]

driver info dump: https://gist.github.com/lleszczu/c537d4608ee3de44508c78de277b7f32

[OpenStack Infra (hudson-openstack)]

Change abandoned by Tuan Luong-Anh (<email address hidden>) on branch: master
Review: https://review.openstack.org/376322

[Dmitry Tantsur (divius)]

I was able to confirm this locally. The issue has two parts. First, we don't reset is_next_boot_persistent to True when a user requests persistent boot. Second, for some reason after the first reboot is_next_boot_persistent gets unconditionally set to False.

[Dmitry Tantsur (divius)]

The first problem is solved by adding the following line after https://github.com/openstack/ironic/blob/1c339b6806580719d20b303d4506c754b9c59e96/ironic/drivers/utils.py#L223:

 driver_internal_info['is_next_boot_persistent'] = True

Still unclear to me what causes the second problem.

[Tuan (tuanla)]

Reproduce bug: http://paste.openstack.org/show/585158/

[Tuan (tuanla)]

Hi Dmitry Tantsur, Łukasz Leszczuk,

Following guide from Dmitry Tantsur and i debug and test in my server show that when set ipmi_force_boot_device and node boot order is set to pxe will run persistent = False in function set_boot_device(self, task, device, persistent=False):
https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ipmitool.py#L912

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/376322
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=6fa142160e99ef6433a6f200511ef78f66b19f45
Submitter: Jenkins
Branch: master

commit 6fa142160e99ef6433a6f200511ef78f66b19f45
Author: Luong Anh Tuan <email address hidden>
Date: Mon Sep 26 16:06:28 2016 +0700

    Fix setting persistent boot device does not work

    - The old value 'is_next_boot_persistent'=False of "driver_internal_info"
    is still in database, Because when persistent set is True we didn't set
    'is_next_boot_persistent'=True. This will lead to get_boot_device work
    wrong in response boot information.

    https://github.com/openstack/ironic/blob/70b992c/ironic/drivers/modules/ipmitool.py#L975
    or
    https://github.com/openstack/ironic/blob/70b992c/ironic/drivers/modules/ipminative.py#L501

    Thus we have to pop "is_next_boot_persistent" to fix the problem.

    Co-Authored-By: Dmitry Tantsur <email address hidden>
    Change-Id: I79efed519b2bacf178f078b338394ca0c4e87d4f
    Closes-bug: #1626453

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ironic 7.0.0 release.