Lack of chassis_uuid field in OSC plugin baremetal node show output

Bug #1620749 reported by Kyrylo Romanenko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Low
Vladyslav Drok
python-ironicclient
Fix Released
Medium
Vadim Hmyrov

Bug Description

There is chassis_uuid field in node-show output to show which chassis this node belongs to:

stack@kromanenko-ironicclient:~/python-ironicclient$ ironic node-show node1
+------------------------+--------------------------------------+
| Property | Value |
+------------------------+--------------------------------------+
| chassis_uuid | |
...

And there is no such field in OSC plugin "baremetal node show" subcommand output.

stack@kromanenko-ironicclient:~/python-ironicclient$ openstack baremetal node show node1
http://paste.openstack.org/show/567235/

Environment:
Devstack from master branches of components
ironic --version
1.7.0
openstack --version
3.2.1

Revision history for this message
Dmitry Tantsur (divius) wrote :

Hmm, maybe it only appears for non-empty chassis? anyway, I agree that we should always show it, even if empty.

Changed in python-ironicclient:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Kyrylo Romanenko (kromanenko) wrote :

Really, i can see that chassis_uuid field appeared when i added node to chassis.
$ openstack baremetal node show b41e559b-62be-49da-ab1e-2d29e021d6b7

+------------------------+-------------------------------------------------------------------------------------------+
| Field | Value |
+------------------------+-------------------------------------------------------------------------------------------+
| chassis_uuid | 007e7259-40e2-4362-a7d2-53f56aa32b3b |

BTW, i added it be means of ironicclient CLI, and i can not figure hot to do it with OSC plugin commands.

Vadim Hmyrov (vhmyrov)
Changed in python-ironicclient:
assignee: nobody → Vadim Hmyrov (vhmyrov)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-ironicclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/370764

Changed in python-ironicclient:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/374811

Changed in ironic:
assignee: nobody → Vladyslav Drok (vdrok)
status: New → In Progress
Dmitry Tantsur (divius)
Changed in ironic:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/374811
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=d42a94a130e6e1800b20d8f4ab01238f59a27eb7
Submitter: Jenkins
Branch: master

commit d42a94a130e6e1800b20d8f4ab01238f59a27eb7
Author: Vladyslav Drok <email address hidden>
Date: Thu Sep 22 16:19:34 2016 +0300

    Always return chassis UUID in node's API representation

    It should be returned no matter if a node belongs to a chassis (in
    which case it is that chassis' UUID) or not (in which case it should
    be None).

    Closes-Bug: #1620749
    Change-Id: If088f604ad9bb766d591d29466fdd1456734c8df

Changed in ironic:
status: In Progress → Fix Released
Changed in python-ironicclient:
assignee: Vadim Hmyrov (vhmyrov) → Sam Betts (sambetts)
Changed in python-ironicclient:
assignee: Sam Betts (sambetts) → Vladyslav Drok (vdrok)
Vladyslav Drok (vdrok)
Changed in python-ironicclient:
assignee: Vladyslav Drok (vdrok) → Vadim Hmyrov (vhmyrov)
Changed in python-ironicclient:
assignee: Vadim Hmyrov (vhmyrov) → Vladyslav Drok (vdrok)
Vladyslav Drok (vdrok)
Changed in python-ironicclient:
assignee: Vladyslav Drok (vdrok) → Vadim Hmyrov (vhmyrov)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-ironicclient (master)

Reviewed: https://review.openstack.org/370764
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=d35a75cbb00c0a5be831b357f15bade92f356a1d
Submitter: Jenkins
Branch: master

commit d35a75cbb00c0a5be831b357f15bade92f356a1d
Author: Vadim Hmyrov <email address hidden>
Date: Thu Sep 15 08:30:19 2016 -0400

    Fix display of chassis UUID field if empty

    When calling OSC commands "openstack baremetal node create" or
    "openstack baremetal node show" the field "chassis_uuid" should be
    displayed even if it is empty.

    This patch also updated the test schema for the ironic --json node-*
    command as chassis_uuid will now appear as 'null' when the node isn't
    associated with a chassis.

    Change-Id: Ic10eb9ef908c12d5c71c1df407bfb66079a25703
    Closes-Bug: #1620749

Changed in python-ironicclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-ironicclient 1.8.0

This issue was fixed in the openstack/python-ironicclient 1.8.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ironic 7.0.0

This issue was fixed in the openstack/ironic 7.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.