ironic using public endpoint to configure ipxe template during deployment

[James Slagle]

ironic is using the public endpoint to configure ipxe template during deployment. it should instead be using the internal endpoint.

this issue was discovered in tripleo-ci where we configure the public endpoint for the baremetal service with ssl. IPA then fails to deploy the instance because the the IPA image we build does not implicitly trust the CA of the configured server certificate used by ironic api/conductor.

I believe I tracked the issue to this commit:
https://review.openstack.org/#/c/236982/

Particularly, the code in ironic/common/keystone.py, get_service_url passes interface_type=endpoint_type to session.get_endpoint. interface_type should actually be interface, see:
http://git.openstack.org/cgit/openstack/keystoneauth/tree/keystoneauth1/identity/base.py#n159

the code silently does the wrong thing since it accepts a **kwargs, and ends up defaulting to the public endpoint.

[James Slagle (james-slagle)]

patch: https://review.openstack.org/#/c/355537/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/355537
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=96bca2db24811ad26f491f145c99ebfa4867479e
Submitter: Jenkins
Branch: master

commit 96bca2db24811ad26f491f145c99ebfa4867479e
Author: James Slagle <email address hidden>
Date: Mon Aug 15 11:43:20 2016 -0400

    Fix key word argument interface_type -> interface

    When calling session.get_endpoint, the key word argument to specify the
    interface type (public, admin, internal), is "interface", not
    "interface_type". This was causing the public endpoint to be returned
    instead of the internal endpoint.

    Change-Id: I77f697e74769cd622fb30f6b065e8645ba5cc39f
    Closes-Bug: #1613331

[Brent Eagles (beagles)]

Was the ironic patch the only one required to fix this bug?