Nodes should enter 'clean wait' state during a cleaning reboot

[Jay Faulkner]

A node that's rebooted due to a clean step having reboot_requested: True will not be transitioned to clean wait during the reboot process.

Expected flow:
CLEANING [ramdisk booted, runs clean step with reboot_requested] -> CLEAN WAIT [while performing the cleaning reboot]

Current behavior:
Node remains in CLEANING regardless of if a ramdisk is booting or not.

The state transitions should likely happen here: https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/agent_base_vendor.py#L305

[Aline Bousquet (alineb)]

Hi Rebecca,
Are you still working on this bug?
Thanks

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/392584

[Anup (anup-d-navare)]

Hi Aline,

Are you still working on this bug?
Thanks

[Aline Bousquet (alineb)]

Hi Anup,
I’m not currently working on this: feel free to work on it.
Thanks

[Jay Faulkner (jason-oldos)]

Looking at https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/agent_base_vendor.py#L487-L502 -- if any bug exists, it's that on cleaning_reboot the node will never re-enter CLEANING while the node is being cleaning_rebooted. I don't think that's a big deal, and I'm closing this bug as fixed.

I had, at some point, personally verified this bug existed; it appears to have been fixed during the implementation of Manual Cleaning. Marking as resolved.