Split unit and functional tests

Bug #1607679 reported by Tang Chen
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Invalid
Medium
Unassigned

Bug Description

Now, Ironic is known as a project without functional tests. But actually, a part of unit tests in Ironic do start a server using pecan, using the same configuration as those in the real code. So they look more like functional tests, but they do fake many calls.

In one word, unit tests and functional tests in Ironic are now mixed. If we want to do better functional tests for Ironic, we should split them first.

This RFE is related to the one below:
https://bugs.launchpad.net/ironic/+bug/1491670

Tang Chen (tangchen)
Changed in ironic:
assignee: nobody → Tang Chen (tangchen)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/348965

Changed in ironic:
status: New → In Progress
Tang Chen (tangchen)
description: updated
summary: - [REF] Split unit and functional tests
+ [RFE] Split unit and functional tests
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/349421

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/350365

Dmitry Tantsur (divius)
summary: - [RFE] Split unit and functional tests
+ Split unit and functional tests
Changed in ironic:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/356188

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/356287

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ironic (master)

Change abandoned by Tang Chen (<email address hidden>) on branch: master
Review: https://review.openstack.org/348965
Reason: Merged to https://review.openstack.org/#/c/349421/

Changed in ironic:
assignee: Tang Chen (tangchen) → jiang wei (timjiang)
yongjie.xu (yongjie.xu)
Changed in ironic:
assignee: jiang wei (timjiang) → yongjie.xu (yongjie.xu)
Revision history for this message
Vladyslav Drok (vdrok) wrote :

All the related patches are abandoned, setting to triaged.

Changed in ironic:
assignee: yongjie.xu (yongjie.xu) → nobody
status: In Progress → Triaged
Revision history for this message
Jay Faulkner (jason-oldos) wrote :

I'm not saying we shouldn't or don't want to do this, but it's not useful having the bug around unless someone is interested in taking up this work.

Changed in ironic:
status: Triaged → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.