create-node.sh fails with IRONIC_VM_LOG_CONSOLE=False

[Yuiko Takada]

When IRONIC_VM_LOG_CONSOLE=False in devstack/local.conf, devstack/tools/ironic/scripts/create-node.sh fails:

2016-06-06 05:19:06.065 | + NAME=node-0
2016-06-06 05:19:06.065 | + CPU=1
2016-06-06 05:19:06.065 | + MEM=3072000
2016-06-06 05:19:06.065 | + DISK=11
2016-06-06 05:19:06.065 | + ARCH=x86_64
2016-06-06 05:19:06.065 | + BRIDGE=brbm
2016-06-06 05:19:06.065 | + EMULATOR=/usr/bin/qemu-system-x86_64
2016-06-06 05:19:06.065 | + VBMC_PORT=6230
2016-06-06 05:19:06.065 | + LOGDIR=qcow2
2016-06-06 05:19:06.065 | + DISK_FORMAT=
...
2016-06-06 05:19:06.099 | + virsh vol-create-as default node-0. 11G --format
2016-06-06 05:19:06.102 | error: expected syntax: --format <string>
2016-06-06 05:19:06.107 | +/opt/stack/ironic/devstack/lib/ironic:create_bridge_and_vms:1 exit_trap

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/325732

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/325732
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=9a1aeb76da2ed53e042a94ead8640af9374a10bf
Submitter: Jenkins
Branch: master

commit 9a1aeb76da2ed53e042a94ead8640af9374a10bf
Author: Yuiko Takada Mori <email address hidden>
Date: Mon Jun 6 14:39:20 2016 +0900

    Fix parameter create-node.sh

    When IRONIC_VM_LOG_CONSOLE is set in devstack/local.conf,
    devstack/tools/ironic/scripts/create-node.sh fails with below error message.

    expected syntax: --format <string>

    This error occurs because when IRONIC_VM_LOG_CONSOLE is set False,
    log_arg is passed with empty string to
    devstack/tools/ironic/scripts/create-node.sh.
    This patch set fixes parameter order of
    devstack/tools/ironic/scripts/create-node.sh, and also
    create-node.sh has too many parameters, so fix to use getopts.

    Change-Id: Ibdfff27e2c0119f8261f2324233acbeea6612d79
    Closes-bug: #1589370

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/334731

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/334731
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=e75ff03b6e826e3811dbdb3648a7bd2ac75c8b9d
Submitter: Jenkins
Branch: master

commit e75ff03b6e826e3811dbdb3648a7bd2ac75c8b9d
Author: Yuiko Takada Mori <email address hidden>
Date: Tue Jun 28 11:14:21 2016 +0900

    Follow-up patch of 9a1aeb76da2ed53e042a94ead8640af9374a10bf

    This patch set removes unused option.

    Change-Id: I2fba6fd7800cab98e783fc29f2d60d5ecfdde458
    Partial-Bug: #1589370

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/ironic 6.1.0 release.