start_iscsi_target fails on Mitaka-era IPA ramdisk with master ironic

[Jim Rollenhagen]

Mitaka IPA does not accept the wipe_disk_metadata parameter, and so master ironic does not work with it.

2016-05-20 08:55:01.087 2439 ERROR ironic.drivers.modules.agent_base_vendor [req-f7a852ff-37cd-4e84-941e-c3f73d8f9efe - - - - -] Asynchronous exception for node 432de453-38cc-4bcb-8f93-786f56e02da2: Node failed to get image for deploy. Exception: Failed to deploy instance: Failed to start the iSCSI target to deploy the node 432de453-38cc-4bcb-8f93-786f56e02da2. Error: {u'message': u"start_iscsi_target() got an unexpected keyword argument 'wipe_disk_metadata'", u'code': 500, u'type': u'TypeError', u'details': u''}
2016-05-20 08:55:01.087 2439 ERROR ironic.drivers.modules.agent_base_vendor Traceback (most recent call last):
2016-05-20 08:55:01.087 2439 ERROR ironic.drivers.modules.agent_base_vendor File "/opt/stack/new/ironic/ironic/drivers/modules/agent_base_vendor.py", line 486, in heartbeat
2016-05-20 08:55:01.087 2439 ERROR ironic.drivers.modules.agent_base_vendor self.continue_deploy(task, **kwargs)
2016-05-20 08:55:01.087 2439 ERROR ironic.drivers.modules.agent_base_vendor File "/opt/stack/new/ironic/ironic/conductor/task_manager.py", line 140, in wrapper
2016-05-20 08:55:01.087 2439 ERROR ironic.drivers.modules.agent_base_vendor return f(*args, **kwargs)
2016-05-20 08:55:01.087 2439 ERROR ironic.drivers.modules.agent_base_vendor File "/opt/stack/new/ironic/ironic/drivers/modules/iscsi_deploy.py", line 876, in continue_deploy
2016-05-20 08:55:01.087 2439 ERROR ironic.drivers.modules.agent_base_vendor uuid_dict_returned = do_agent_iscsi_deploy(task, self._client)
2016-05-20 08:55:01.087 2439 ERROR ironic.drivers.modules.agent_base_vendor File "/opt/stack/new/ironic/ironic/drivers/modules/iscsi_deploy.py", line 356, in do_agent_iscsi_deploy
2016-05-20 08:55:01.087 2439 ERROR ironic.drivers.modules.agent_base_vendor raise exception.InstanceDeployFailure(reason=msg)
2016-05-20 08:55:01.087 2439 ERROR ironic.drivers.modules.agent_base_vendor InstanceDeployFailure: Failed to deploy instance: Failed to start the iSCSI target to deploy the node 432de453-38cc-4bcb-8f93-786f56e02da2. Error: {u'message': u"start_iscsi_target() got an unexpected keyword argument 'wipe_disk_metadata'", u'code': 500, u'type': u'TypeError', u'details': u''}
2016-05-20 08:55:01.087 2439 ERROR ironic.drivers.modules.agent_base_vendor

[Ruby Loo (rloo)]

patch to address this: https://review.openstack.org/#/c/319183/

[OpenStack Infra (hudson-openstack)]

Change abandoned by Dmitry Tantsur (<email address hidden>) on branch: master
Review: https://review.openstack.org/322932
Reason: it looks like we decided to not do this

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/319183
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=ba83fb1bb45b63e056c87c3bbf42cabaade7865c
Submitter: Jenkins
Branch: master

commit ba83fb1bb45b63e056c87c3bbf42cabaade7865c
Author: Vladyslav Drok <email address hidden>
Date: Mon May 30 23:02:37 2016 +0300

    Gracefully degrade start_iscsi_target for Mitaka ramdisk

    Currently calling this code blows up if using an older ramdisk. If
    default values for 'portal_port' or 'wipe_disk_metadata' parameters
    are set, do not pass it to IPA to workaround this problem. If
    start_iscsi_target fails and wipe_disk_metadata is True, try to
    start iSCSI without it, if custom portal_port is requested, tell the
    user that either ramdisk should be updated or default port should be
    used.

    Closes-Bug: #1584005
    Co-Authored-By: Vladyslav Drok <email address hidden>
    Change-Id: I319fb18bb8ff58970c219cc4f4dba7b54e239bd4

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/ironic 6.0.0 release.