No need to do node clean if it deleted from a deploy failed state
Bug #1578947 reported by
Zhenguo Niu
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ironic |
Opinion
|
Undecided
|
Zhenguo Niu | ||
Bug Description
Currently we always do node clean while tearing down a node, this is a must if we delete an active node, but it seems not needed if deleting a deployed failed node, as disk erasing always takes long time to finish and before deploying we just cleaned up it, so if the node not in active state, the deleting process should not include cleaning action.
| Changed in ironic: | |
| assignee: | nobody → Zhenguo Niu (niu-zglinux) |
Revision history for this message
| Dmitry Tantsur (divius) wrote | #1 |
| Changed in ironic: | |
| status: | New → Opinion |
Revision history for this message
| Jim Rollenhagen (jim-rollenhagen) wrote | #2 |
To post a comment you must log in.
I disagree with that. We generally do not know at which state the deployment failed, it's pretty possible that we've already put the image on the machine. And the image might contain sensitive things, so we'd better clean it. Also cleaning is not only about wiping the hard drive, more actions can be required by various drivers.