[RFE] Deprecate and remove the *_ssh drivers

[Sam Betts]

The *_ssh drivers were added to Ironic to help with virtualised testing and were required until recently because there was no other way for Ironic to manage a VM. VirtualBMC now allows us to control VMs through the IPMI drivers letting us simulate baremetal even more closely. Thanks to this I now propose we remove the *_ssh drivers as they only lead to confusion from people who assume that all Ironic drivers work with hardware, and prevent conversations like this:

< ------- > one thing i understood from docs is that hardware should support IPMI in order to use the IPMI driver
< ------- > is it correct ?
< ------- > my hardware does not have IPMI controller ...
< ------- > so i changed my driver to pxe_ssh from pxe_ipmitool

Timeline:

Newton development cycle:

- Pull VirtualBMC into the Ironic project umbrella

- Deprecate SSH interfaces for removal in OpenStack Ocata that includes: SSHPower, SSHManagement and ssh.ShellInABoxConsole in-tree drivers affected are pxe_ssh, agent_ssh, and fake_ssh.

- Make gate IPMITool tests that use VirtualBMC voting

Ocata development cycle:

- Remove *_ssh gate tests and move them to using ipmitool drivers
- Remove support for *_ssh drivers

[Dmitry Tantsur (divius)]

+1 :)

[Pavlo Shchelokovskyy (pshchelo)]

So, we missed Ocata for this, and the currently agreed upon deadline is Pike milestone 3.

Currently we have 4 jobs running devstack that deploy nodes using *_ssh drivers:
- gate-tempest-dsvm-ironic-multitenant-network-ubuntu-xenial
- gate-grenade-dsvm-ironic-ubuntu-xenial
- gate-grenade-dsvm-ironic-inspector-ubuntu-xenial
- gate-tempest-dsvm-python-ironicclient-src-ubuntu-xenial

I'll start testing the switch by patches to devstack-gate etc.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/439721

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/439781

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/ocata
Review: https://review.openstack.org/440299

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/newton
Review: https://review.openstack.org/440300

[VIncent S. Cojot (vincent-m)]

I am not sure I agree with this train of thought:

pxe_ssh used to support vbox, virsh, vmware, parallels and xenserver.
virtualbmx only supports virsh/libvirt.

Isn't there a gap for those not using virsh/libvirt?
Thanks,

[OpenStack Infra (hudson-openstack)]

Change abandoned by Joshua Hesketh (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/439781
Reason: This branch (stable/mitaka) is at End Of Life

[OpenStack Infra (hudson-openstack)]

Change abandoned by Pavlo Shchelokovskyy (<email address hidden>) on branch: stable/newton
Review: https://review.openstack.org/440300
Reason: all gates have been moved to not use *_ssh as deploy drivers

[OpenStack Infra (hudson-openstack)]

Change abandoned by Pavlo Shchelokovskyy (<email address hidden>) on branch: master
Review: https://review.openstack.org/439721
Reason: all gates have been moved to not use *_ssh as deploy drivers

[OpenStack Infra (hudson-openstack)]

Change abandoned by Pavlo Shchelokovskyy (<email address hidden>) on branch: stable/ocata
Review: https://review.openstack.org/440299
Reason: all gates have been moved to not use *_ssh as deploy drivers

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/481688
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=3d9895cc0b6b9e41cdc5cc389d10504cd31ffa9d
Submitter: Jenkins
Branch: master

commit 3d9895cc0b6b9e41cdc5cc389d10504cd31ffa9d
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Fri Jul 7 18:23:02 2017 +0300

    Remove SSH-based driver interfaces and drivers

    SSH drivers are being unsupported for about a year now. All current
    stable branches of ironic are officially supporting IPMI-capable HW
    simulation via virtualbmc.
    All ironic-related gate jobs have already been switched
    to not use or enable those drivers.

    This patch finally removes SSH-based power and managemtnt driver interfaces
    and all classic drivers using those from ironic code and documentation.
    Related exceptions and `ssh_connect` function, together with dependency
    on `paramiko` package are removed as well.

    Change-Id: Ieda7249b9cd78e3be1eff37804996295fc8d3969
    Closes-Bug: #1570301
    Depends-On: I9b60c9fa24652e9e64e787cd4e5b0152f51e7a28

[Kaifeng Wang (kaifeng)]

Just a reminder, there are some codes left at bifrost, is there plan to remove them too?
not sure if we add bifrost to this bug for tracking.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/492819

[OpenStack Infra (hudson-openstack)]

Change abandoned by Wang KaiFeng (<email address hidden>) on branch: master
Review: https://review.openstack.org/492819
Reason: ssh_key_contents masking will be kept to avoid breaking out-of-tree usage.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ironic 9.0.0 release.