It is possible to remove node name in any api version

Bug #1565663 reported by Vladyslav Drok on 2016-04-04
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Won't Fix
Low
Vasyl Saienko

Bug Description

The following piece of code in NodesController patch method checks that it is not possible to set an incorrect name:

        name = api_utils.get_patch_value(patch, '/name')
        if name:
            error_msg = _("Node %(node)s: Cannot change name to invalid "
                          "name '%(name)s'") % {'node': node_ident,
                                                'name': name}
            self._check_name_acceptable(name, error_msg)

But it does allow to remove name via patch operation, no matter what api version is specified.

Vladyslav Drok (vdrok) on 2016-04-04
Changed in ironic:
assignee: nobody → Vladyslav Drok (vdrok)

Fix proposed to branch: master
Review: https://review.openstack.org/300983

Changed in ironic:
status: New → In Progress
Dmitry Tantsur (divius) on 2016-04-04
Changed in ironic:
importance: Undecided → Low
Changed in ironic:
assignee: Vladyslav Drok (vdrok) → Zhenguo Niu (niu-zglinux)
Vladyslav Drok (vdrok) on 2016-04-05
Changed in ironic:
assignee: Zhenguo Niu (niu-zglinux) → Vladyslav Drok (vdrok)
Changed in ironic:
assignee: Vladyslav Drok (vdrok) → Vasyl Saienko (vsaienko)
Vladyslav Drok (vdrok) wrote :

On the meeting 12.04.2016 it was decided that it is a breaking change, that requires a new microversion, and adding that to fix this bug does not make much sense.

Changed in ironic:
status: In Progress → Won't Fix
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers