Cleaning process with maintenance mode should be prevented

[Yushiro FURUKAWA]

Currently, manual cleaning for an ironic node which is maintenance mode has prevented.
    $ ironic node-set-provision-state $NODE_UUID clean --clean_steps [''']

However, following steps hasn't prevented yet. Therefore, I think it should be prevented too.

[Condition]
  (A) and (B) or
  (A) and (C) or
  (A) and (B) and (C)

  (A):The ironic node: maintenance = True
  (B):/ironic.conf: automated_clean = True
  (C):The ironic node: clean_step is not None

[Not prevented action]
  (1) Change provision state to "manage"
      $ ironic node-set-provision-state $NODE_UUID manage
  (2) Change provision state from "manage" to "provide"
      $ ironic node-set-provision-state $NODE_UUID provide

      If ironic.conf has 'automated_clean = True' or manually configured
      clean_step exists, cleaning process should be executed.

[What happens?]
After executing (2) with above condition, cleaning process runs but nothing
to do while cleaning with following debug message.

    LOG.debug('Heartbeat from node %(node)s in maintenance mode; '
              'not taking any action.', {'node': node.uuid})

I think it is difficult for operator to realize this situation.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/299097

[Vasyl Saienko (vsaienko)]

Related mail thread is: http://lists.openstack.org/pipermail/openstack-dev/2016-September/103114.html
The decision was to not prevent launch cleaning for nodes in maintenance mode. But since cleaning can't succeed in this case we should move node to CLEAN FAILED state.

Related fix: https://review.openstack.org/#/c/366828/

[OpenStack Infra (hudson-openstack)]

Change abandoned by Yushiro FURUKAWA (<email address hidden>) on branch: master
Review: https://review.openstack.org/299097
Reason: Let's follow alternative patch https://review.openstack.org/#/c/366828/

Thanks for reviewing my patch, Avinash, David, Naohiro, Vladyslav, Vasyl, Julia, Mikhail and Madhuri!!