iLO does not utilize the UEFI capability for cleaning

[Purandhar Sairam Mannidi]

When a baremetal node is registered with any ilo driver with boot mode as UEFI, change the provision state from available to manage and then to provide.

Before registering a node, make sure the node boot mode is set to BIOS.

When the provision state is changed from available to provide, cleaning process is initiated and it is expected that the node is first changed to UEFI boot mode and boot with UEFI capable deploy images.

It is observed that irrespective of boot mode passed during the node registration, node is trying to boot with existing boot mode which in this case is BIOS and fails to boot with deploy images as they are EFI boot only.

[Shivanand Tendulker (stendulker)]

The 'boot_mode' set in the node->properties->capabilities is meant for deploy. Any of these properties cannot be safely used for setting boot mode during cleaning. There could be contradictory capability values. Say 'trusted_boot=true' with 'boot_mode=bios'. If required driver would need to carve out new 'driver_info' property say, 'cleaning_boot_mode' to be used during cleaning operation. But again this would be per node basis and adds to operator overhead without much of benefit as there are no boot mode specific tasks.

Anyways, iLO driver do provide 'iso' element in DIB to create bios cum uefi bootable iso to avoid such complication of setting per node boot mode for cleaning operations.

[Dmitry Tantsur (divius)]

There are machines which don't have BIOS mode at all, so it's still a valid bug.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/540793

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/540793
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=216ad852fa17d508f119efdd7c77e2583d6ae8b8
Submitter: Zuul
Branch: master

commit 216ad852fa17d508f119efdd7c77e2583d6ae8b8
Author: mallikarjuna.kolagatla <email address hidden>
Date: Mon Feb 5 08:58:36 2018 +0000

    Updates boot mode on the baremetal as per `boot_mode`

    This patch modifies the ilo drivers to use the
    `boot_mode` capability for cleaning and update the
    same on the baremetal.

    Change-Id: I5b095cac47890e117866f0569f69148deff173b7
    Closes-Bug: #1559835

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ironic 11.0.0 release.