Can not update node after aborting cleaning ("clean wait" state)

[Lucas Alvares Gomes]

When aborting a node in "clean wait" state the node will go to "clean fail", from there the operator may want to move it to "manageable" and edit some information in the node before restart cleaning again. Currently ironic do not clean the target_provision_state on the ERROR states and apparently after we move it from "clean fail" to "manageable" the target_provision_state still set which causes Ironic to fail as below when we try to update the node:

[stack@localhost devstack]$ ironic node-update node-0 add extra/foo=bar
Node node-0 can not be updated while a state transition is in progress. (HTTP 409)

See the full logs here: http://paste.openstack.org/show/490490/

[Sam Betts (sambetts)]

We've hit this issue in downstream testing, during testing a mistake was made in the node configuration which caused cleaning to fail. The node was then moved to manageable successfully however because the target state wasn't cleared, we could not update the node's information because it still believes its in a transition. This means our only choices were to manually edit the nodes record via mysql or delete the node and recreate it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/293554

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/293554
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=aa4d3fa0220450517bebd621b6db0f8ca1fba0ca
Submitter: Jenkins
Branch: master

commit aa4d3fa0220450517bebd621b6db0f8ca1fba0ca
Author: Lucas Alvares Gomes <email address hidden>
Date: Wed Mar 16 16:37:54 2016 +0000

    Make sure target state is cleared on stable states

    When a node moves to a stable provisioning state and there's no extra
    processing to be done (callback) we have to make sure that the
    target_provision_state is cleared (set to None) indicating that the node
    is not transitioning to any other state.

    Closes-Bug: #1557497
    Change-Id: Id4f05ed3c6acbeda07a726049e2857fcb96338db

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/ironic 5.1.0 release.