baremetal machine fail in local boot in virtualbox

[bin Yu]

The virtualbox driver can work in net boot mode, but fails to finish deploy and restart the virtualbox VMs in local boot mode which boots from the local hard disk.

The main problem is that ironic set the boot sequence firstly and them restart the machine, but changing boot sequence while VMs is powered on is not supported in virtualbox. So we should shutdown the VMs before change it boot sequence.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/290951

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/290951
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=d76f12f4f91a01cab447ba0833816852cba873d3
Submitter: Jenkins
Branch: master

commit d76f12f4f91a01cab447ba0833816852cba873d3
Author: bin yu <email address hidden>
Date: Wed Mar 16 02:16:09 2016 +0000

    Fix VirtualBox cannot set boot device when powered on

    When the VirtualBox VMs is powered on, Ironic cannot set the boot
    device. As a result, VirtualBox driver cannot finish deploying
    local harddisk boot VMs and also set and get Virtualbox VMs's
    boot devices correctly.

    Solution: We get boot device from set_boot_device and store the
    target boot device in driver_internal_info. Before next starting up
    we set the boot device and clean target_boot_device information,
    if the target_boot_device is None, we just skip setting boot device.
    For the get_boot_device call, if the VMs is powered off, we call
    remotebox to get current boot device. otherwise, we return the target
    boot device from driver_internal_info(if target_boot_device
    is not None) or we call remotebox to return the current boot device.
    Returning target boot device when VMs is powered on will avoid the
    problem that even users set the target boot device while returning
    the last boot device.

    Change-Id: Ice489ba642bf093fe7015aa97e6a92717f676118
    Closes-Bug: #1554908

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/ironic 6.0.0 release.