[RFE] In-band introspection of diskless nodes

[aeva black]

Problem: when no local disks are detected, ironic-inspector fails to process the host at all.

2016-03-07 22:43:39.171 20423 DEBUG ironic_inspector.main [-] Returning error to client: The following problems encountered: root disk is not supplied by the ramdisk and root_disk_selection hook is not enabled error_response /usr/local/lib/python2.7/dist-packages/ironic_inspector/main.py:65

UPD: proposal from dtantsur:

We need to distinguish nodes with and without disks. I don't think we should silently ignore missing root device for nodes that do not have remote volumes.

Create a new ironic-inspector API parameter "diskless" (boolean, default False). If this parameter is passed when starting the introspection, do not fail on missing disks and/or root device. Instead, set local_gb=0 to indicate missing root device.

Modify the ironic Inspector interface to pass "diskless" based on whether we have a valid storage interface.

[Dmitry Tantsur (divius)]

I'm marking this bug as an RFE, cause not having local disks is something that does not make sense to Ironic right now. We at least have to provide local_gb. As Ironic is probably getting boot from volume support, things will change, and inspector will have to adapt.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/326620

[OpenStack Infra (hudson-openstack)]

Change abandoned by Dmitry Tantsur (<email address hidden>) on branch: master
Review: https://review.openstack.org/326620
Reason: I won't work on this for now

[Jim Rollenhagen (jim-rollenhagen)]

Makes sense to me, +1

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/326620
Committed: https://git.openstack.org/cgit/openstack/ironic-inspector/commit/?id=6e2ea6242d8b5cd7e1e216b32185937aa583d84a
Submitter: Jenkins
Branch: master

commit 6e2ea6242d8b5cd7e1e216b32185937aa583d84a
Author: Dmitry Tantsur <email address hidden>
Date: Tue Jun 7 18:18:56 2016 +0200

    Allow diskless nodes introspection

    There is a demand to use introspection on diskless nodes to figure out
    what is possible to figure out.

    We might need more changes to properly support diskless nodes, this
    change is just to allow people to play with it.

    The property ``local_gb == 0`` for a diskless node.

    Change-Id: I21b2f2c069fdbf767367ec3d1fbf77bab6292b25
    Partial-Bug: #1554243

[milan k (vetrisko)]

Fix for inspector was released in the version 5.0

[Ruby Loo (rloo)]

A bit late :-), but jroll (comment #4) and dtantsur [1] are good with approving this.

[1] around 15:42, http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2017-11-21.log.html

[Julia Kreger (juliaashleykreger)]

This was an inspector-only change. Marking invalid for ironic itself.