DEFAULT_INSTANCE_TYPE not honored in the new Ironic's devstack plugin

Bug #1546706 reported by Mauro S M Rodrigues on 2016-02-17
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
In Progress
Medium
Mauro S M Rodrigues
tempest
Undecided
Mauro S M Rodrigues

Bug Description

When we use devstack + tempest to test baremetal, specially w/ real hardware, we expect to use DEFAULT_INSTANCE_TYPE=baremetal to allow us to use an appropriate baremetal flavor which is created at lib/ironic.

If you take a closer look into the devstack.log file from a recent run of dsvm-ironic-pxe_ssh (like http://logs.openstack.org/04/280204/4/check/gate-tempest-dsvm-ironic-pxe_ssh/87a21ff/logs/devstacklog.txt.gz ) and look for the string "awk '/ baremetal / { print $2 }'", which is the point where lib/tempest looks for a flavor with the name specified by DEFAULT_INSTANCE_TYPE, you'll note it never finds the 'baremetal' flavor. If you look for the moment the 'baremetal' flavor is created you'll also notice that is way later in the stack process and thus we have not used 'baremetal' flavor on any of our upstream tests but the generic flavor_ref=1 and flavor_ref_alt=2 (see tempest.conf file from a recent run) which are fine for upstream integration tests since it's made using guests and a small image like cirros fitting in the default flavor capacity. For real hardware though that flavor is not enough, for instance I caught this bug cause cirros doesn't support ppc64 hardware and thus I opted to use fedora as target image, requiring therefore a bigger root_gb than 1gb as flavor_id 1 offers.

Why is this happening? before we move into a devstack plugin, ironic's phases were executed before tempest's cause the files were named 50-ironic and 80-tempest, now devstack's in-tree services are executed before (tempest included) and then the plugins.

Changed in ironic:
assignee: nobody → Mauro S M Rodrigues (maurosr)
Changed in devstack:
assignee: nobody → Mauro S M Rodrigues (maurosr)
Changed in tempest:
assignee: nobody → Mauro S M Rodrigues (maurosr)

Fix proposed to branch: master
Review: https://review.openstack.org/281503

Changed in devstack:
status: New → In Progress
Changed in tempest:
status: New → In Progress

Fix proposed to branch: master
Review: https://review.openstack.org/281505

Changed in ironic:
status: New → In Progress
Dmitry Tantsur (divius) on 2016-02-22
Changed in ironic:
importance: Undecided → Medium

Fix proposed to branch: master
Review: https://review.openstack.org/296237

Changed in devstack:
assignee: Mauro S M Rodrigues (maurosr) → Vasyl Saienko (vsaienko)

Change abandoned by Vasyl Saienko (<email address hidden>) on branch: master
Review: https://review.openstack.org/296237
Reason: abandoned, similar patch already exists https://review.openstack.org/#/c/293954

Change abandoned by Ken'ichi Ohmichi (<email address hidden>) on branch: master
Review: https://review.openstack.org/281505
Reason: Ironic tests have been moved into Ironic repo, so we don't need this way now.

Ken'ichi Ohmichi (oomichi) wrote :

Ironic tests have been moved into Ironic repo already, so it is not necessary to change Tempest side today

Changed in tempest:
status: In Progress → Won't Fix
Sean Dague (sdague) on 2017-06-15
Changed in devstack:
assignee: Vasyl Saienko (vsaienko) → nobody
status: In Progress → New
Sean Dague (sdague) wrote :

Is there still a devstack fix needed?

Changed in devstack:
status: New → Incomplete
Sean Dague (sdague) on 2017-06-28
Changed in devstack:
assignee: nobody → Vasyl Saienko (vsaienko)
status: Incomplete → In Progress

Change abandoned by Julia Kreger (<email address hidden>) on branch: master
Review: https://review.openstack.org/281506
Reason: Marking abandoned as this change was last revised over a year ago. If we wish to move forward on this change, we can always restore it.

Dr. Jens Harbott (j-harbott) wrote :

No review in progress. Given the age of the bug report, it is unclear whether this is still a valid issue. Please update with fresh logs if this issue still persists.

Changed in devstack:
assignee: Vasyl Saienko (vsaienko) → nobody
status: In Progress → Incomplete
no longer affects: devstack
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers