Use JSON schema to verify clean steps

Bug #1543618 reported by Ruby Loo on 2016-02-09
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Low
Sana Khan

Bug Description

When a user does a manual clean, they specify the clean steps to be performed. Ironic verifies the inputted clean steps in ironic/api/controllers/v1/node.py, _check_clean_steps(). It would be better to validate it using a JSON schema as noted by Dmitry Tantsur [1]

[1] https://review.openstack.org/#/c/251995/12/ironic/api/controllers/v1/node.py, line 531.

Tags: api Edit Tag help
Dmitry Tantsur (divius) on 2016-02-09
Changed in ironic:
status: New → Triaged
tags: added: api
Sana Khan (sana.khan) on 2016-02-20
Changed in ironic:
assignee: nobody → Sana Khan (sana.khan)

Fix proposed to branch: master
Review: https://review.openstack.org/285629

Changed in ironic:
status: Triaged → In Progress

Reviewed: https://review.openstack.org/285629
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=1de392ddd4eb36abd3dacf7ac12950db50cfae4b
Submitter: Jenkins
Branch: master

commit 1de392ddd4eb36abd3dacf7ac12950db50cfae4b
Author: Sana Khan <email address hidden>
Date: Sat Feb 27 11:11:20 2016 +0530

    Uses jsonschema library to verify clean steps

    When a user does a manual clean, they specify the clean steps to be performed.
    The inputted clean steps are verified in _check_clean_steps().
    This patch validates the structure of clean_steps using JSON Schema.

    Closes-Bug: #1543618
    Change-Id: I1c915c35ef4d4861b14edb49187b780f1895b1cb

Changed in ironic:
status: In Progress → Fix Released

This issue was fixed in the openstack/ironic 5.1.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers