Wrong spawn error hook in "continue_node_clean" RPC method

Bug #1539118 reported by Yuriy Zveryanskyy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
High
Yuriy Zveryanskyy

Bug Description

There are some problems:
1) Missing first parameter (exception) in current utils.cleaning_error_handler() hook function.
2) It's not needed to set fail state if no free conductor workers, this is driver specific.
IPA driver can obtain a free worker on the next heartbeat(s).

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/273594

Changed in ironic:
assignee: nobody → Yuriy Zveryanskyy (yzveryanskyy)
status: New → In Progress
Dmitry Tantsur (divius)
Changed in ironic:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/273594
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=8c8704e23a4ab3d0bae8a21fd5bef8a97c9c5f13
Submitter: Jenkins
Branch: master

commit 8c8704e23a4ab3d0bae8a21fd5bef8a97c9c5f13
Author: Yuriy Zveryanskyy <email address hidden>
Date: Thu Jan 28 16:39:21 2016 +0200

    Fix spawn error hook in "continue_node_clean" RPC method

    1) utils.cleaning_error_handler() as hook in current code does not
    have an exception parameter that task context manager adds.
    2) It's not needed to set fail state on "NoFreeConductorWorker"
    exception, this is driver specific. IPA driver can obtain a free
    worker on the next heartbeat(s).

    This patch also adds missing tests for error handlers functions.

    Closes-Bug: #1539118
    Change-Id: I9081d5b3437e9be6b68fe9c635b38f84637e93df

Changed in ironic:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/ironic 5.0.0

This issue was fixed in the openstack/ironic 5.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.