Cleaning does not support reboot_requested

[Jay Faulkner]

Despite being referenced in tests and pydocs:

https://github.com/openstack/ironic/blob/701a830ab2869d87a3dd1462637da05d9771dce7/ironic/tests/unit/drivers/modules/ilo/test_deploy.py#L376
https://github.com/openstack/ironic/blob/9b48134615aa6a7406aa1395f175ee1ddec42090/ironic/tests/unit/drivers/modules/test_agent_base_vendor.py#L395
https://github.com/openstack/ironic-python-agent/blob/0144e79df5dab0837a55a981fa23298908af14cf/ironic_python_agent/extensions/clean.py#L33

reboot_requested flag on a clean_step is not honored by cleaning.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/259135

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/259135
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=bf985bcdd94f953b7d72a2c28481cb2f3ff50508
Submitter: Jenkins
Branch: master

commit bf985bcdd94f953b7d72a2c28481cb2f3ff50508
Author: Jay Faulkner <email address hidden>
Date: Wed Mar 23 18:46:03 2016 +0000

    Support reboot_requested bool on agent clean_steps

    After IPA has completed a cleaning step such as upgrading firmware, it
    may require a reboot. Ironic should be the one controlling the power
    state and out of band reboots are preferable to in band reboots.

    Change-Id: Iee3aeea198c556ab9adb9dcfd949d9cffb51418c
    Co-Authored-By: Josh Gachnang <email address hidden>
    Closes-bug: 1526918

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/ironic 6.0.0 release.