[RFE] Extend device hints with disk name

Bug #1526732 reported by Vladyslav Drok
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Wishlist
Lucas Alvares Gomes

Bug Description

Having disk name (like sda) as a part of VALID_ROOT_DEVICE_HINTS simplify deployment of BM with not trivial HDDs configuration. As an example we have servers with 14 x 400 GB SSDs or 12 x 4TB + 2 x 600GB. And it is nearly impossible to specify correctly which disk to write the image to (especially if HW raid is built) with any device hint option provided by the Ironic at the moment. Also having such an option helps disk replacement use case.

Tags: rfe
Vladyslav Drok (vdrok)
Changed in ironic:
status: New → Confirmed
importance: Undecided → Wishlist
tags: added: rfe
Revision history for this message
Lucas Alvares Gomes (lucasagomes) wrote :

I just hit this, when we came up with root device hints we only had in mind sata, scsi and ide disk controllers and for these controllers the name may change on each boot.

Now, other controllers and RAID allows us to set a constant name, we should def include it as part of the root device hints.

Changed in ironic:
assignee: nobody → Lucas Alvares Gomes (lucasagomes)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/269639

Changed in ironic:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/269639
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=0edba8a86ca78cf73780b0f0fca5bbdc56f1e54a
Submitter: Jenkins
Branch: master

commit 0edba8a86ca78cf73780b0f0fca5bbdc56f1e54a
Author: Lucas Alvares Gomes <email address hidden>
Date: Tue Jan 19 13:45:47 2016 +0000

    Extend root device hints to support device name

    This patch is extending the root device hints to support the device name
    as input.

    It's important to note that for SATA, SCSI and IDE disk controllers
    the name is not recommended to be used because the order in which the
    device nodes are added in Linux is arbitrary, resulting in devices like
    /dev/sda and /dev/sdb switching around at boot time. The documentation
    was updated to inform operators about this problem.

    Depends-On: I48d6456c75bbe6ddf16ac6561e5461ca51eb9c37
    Change-Id: I564d68ab1c66505195745c34e16e829b45a00a75
    Closes-Bug: #1526732

Changed in ironic:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/ironic 5.0.0

This issue was fixed in the openstack/ironic 5.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.