[RFE] Add ShellinaboxConsole support for SSH driver

[Vladyslav Drok]

We should implement a console driver that uses shellinabox to add console support for SSH driver.

[Ruby Loo (rloo)]

Specification was approved and is available at http://specs.openstack.org/openstack/ironic-specs/specs/approved/ssh-console-support.html.

Copying this from the old BP (https://blueprints.launchpad.net/ironic/+spec/ssh-console-support):

Gerrit topic: https://review.openstack.org/#q,topic:bp/ssh-console-support,n,z

Spec: https://review.openstack.org/#/c/240781/

Addressed by: https://review.openstack.org/241453
    Add console feature to ssh driver

Addressed by: https://review.openstack.org/256272
    Enable ironic node pty console by default

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/241453
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=dc080b598b45e12010045e6c371ed5f9c9af0713
Submitter: Jenkins
Branch: master

commit dc080b598b45e12010045e6c371ed5f9c9af0713
Author: Zhenguo Niu <email address hidden>
Date: Mon Nov 23 10:43:12 2015 +0800

    Add console feature to ssh driver

    Currently there is no support to get console in dev and
    test environments, this patch implements a console driver
    ShellinaboxConsole to add ability of console access for
    SSH driver using 'virsh console'.

    For non-virsh ssh drivers, a 'GET /v1/drivers/properties'
    request will return False for the console interface (as
    opposed to None) with a 'not supported ...' reason.

    Change-Id: I2764e0cb4b5b489762e00cd266212b902acc0746
    Closes-Bug: #1526305

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/256272
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=24955b21255f1e94fb022ddff61a7971514ac4d5
Submitter: Jenkins
Branch: master

commit 24955b21255f1e94fb022ddff61a7971514ac4d5
Author: Zhenguo Niu <email address hidden>
Date: Fri Dec 11 15:50:26 2015 +0800

    [Devstack]Add ability to enable ironic node pty console

    Make it possible to enable pty console, so that we can test shellinabox
    console with the vm, but in order to not affect the gate logs, we need
    to keep the log console by default.

    Related-bug: #1526305
    Change-Id: I9cb13c85fe1b5d596582dbe15bbd9adf98b03140

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/ironic 5.0.0 release.