Ironic

NotImplementedError misspell

Bug #1524163 reported by Tan Lin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Medium
Tan Lin

Bug Description

In ironic/conductor/rpcapi.py, there are several functions(object_backport_versions(), object_action(), object_class_action_versions) use NotImplemented, which will return nothing useful to user, like below: 'NotImplementedType' is not callable (HTTP 500).

This should be NotImplementedError instead and will return things like: Incompatible conductor version - please upgrade ironic-conductor first (HTTP 500)

Tags: conductor
Tan Lin (tan-lin-good)
summary: - NotImplement misspell
+ NotImplementedError misspell
Tan Lin (tan-lin-good)
Changed in ironic:
assignee: nobody → Tan Lin (tan-lin-good)
Dmitry Tantsur (divius)
Changed in ironic:
importance: Undecided → Medium
status: New → Triaged
tags: added: conductor
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/253365
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=1171e25d1d80ee02cb1a86fa4d9e442e3633115d
Submitter: Jenkins
Branch: master

commit 1171e25d1d80ee02cb1a86fa4d9e442e3633115d
Author: Lin Tan <email address hidden>
Date: Fri Dec 4 15:45:48 2015 +0800

    Correct NotImplemented to NotImplementedError in rpcapi.py

    NotImplemented will not return any useful info to end-user.
    This should be NotImplementedError.

    Change-Id: I4402a1f4f5fd47fd7230359a5c2eb03123f993fa
    Close-Bug: #1524163

Tan Lin (tan-lin-good)
Changed in ironic:
status: Triaged → Fix Committed
Julia Kreger (juliaashleykreger)
Changed in ironic:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.